From: Peter Seiderer <ps.report@gmx.net>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] package/qt5/qt5scxml: install missing QML module
Date: Thu, 1 Mar 2018 11:50:03 +0100 [thread overview]
Message-ID: <20180301115003.6cc39376@gmx.net> (raw)
In-Reply-To: <20180301074610.18946-1-b.bilas@grinn-global.com>
Hello Bartosz,
first thanks for the suggested patch.
On Thu, 1 Mar 2018 08:46:10 +0100, Bartosz Bilas <b.bilas@grinn-global.com> wrote:
> This patch add support for scxml module in QML projects.
> When would you like to use state machines in qml files,
> you get an error like this:
>
> qrc:/MainUI.qml:2 module "QtScxml" is not installed
>
Patch subject: 'qt5scxml: install missing QML module' and
Fixes:
qrc:/MainUI.qml:2 module "QtScxml" is not installed
would be enough (I think the patched lines are self-explanatory)...
>
> Signed-off-by: Bartosz Bilas <b.bilas@grinn-global.com>
> ---
> package/qt5/qt5scxml/qt5scxml.mk | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/package/qt5/qt5scxml/qt5scxml.mk b/package/qt5/qt5scxml/qt5scxml.mk
> index 2d197a2bca..3f0f1a9054 100644
> --- a/package/qt5/qt5scxml/qt5scxml.mk
> +++ b/package/qt5/qt5scxml/qt5scxml.mk
> @@ -35,6 +35,12 @@ define QT5SCXML_INSTALL_TARGET_LIBS
> endef
> endif
>
> +ifeq ($(BR2_PACKAGE_QT5DECLARATIVE_QUICK),y)
> +define QT5SCXML_INSTALL_TARGET_QMLS
> + cp -dpfr $(STAGING_DIR)/usr/qml/QtScxml/ $(TARGET_DIR)/usr/qml/
> +endef
> +endif
> +
The dependency on BR2_PACKAGE_QT5DECLARATIVE_QUICK is not needed, the QtScxml
module is build/installed even without enabled BR2_PACKAGE_QT5DECLARATIVE_QUICK...
With this changes you can add my
Reviewed-by: Peter Seiderer <ps.report@gmx.net>
Regards,
Peter
> ifeq ($(BR2_PACKAGE_QT5BASE_EXAMPLES),y)
> define QT5SCXML_INSTALL_TARGET_EXAMPLES
> cp -dpfr $(STAGING_DIR)/usr/lib/qt/examples/scxml $(TARGET_DIR)/usr/lib/qt/examples/
> @@ -43,6 +49,7 @@ endif
>
> define QT5SCXML_INSTALL_TARGET_CMDS
> $(QT5SCXML_INSTALL_TARGET_LIBS)
> + $(QT5SCXML_INSTALL_TARGET_QMLS)
> $(QT5SCXML_INSTALL_TARGET_EXAMPLES)
> endef
>
next prev parent reply other threads:[~2018-03-01 10:50 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-01 7:46 [Buildroot] [PATCH] package/qt5/qt5scxml: install missing QML module Bartosz Bilas
2018-03-01 10:50 ` Peter Seiderer [this message]
2018-03-01 12:26 ` Bartosz Biłas
2018-03-01 13:52 ` Peter Seiderer
2018-03-02 21:24 ` Thomas Petazzoni
2018-03-03 19:51 ` Peter Seiderer
2018-03-07 14:08 ` Bartosz Biłas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180301115003.6cc39376@gmx.net \
--to=ps.report@gmx.net \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox