Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Seiderer <ps.report@gmx.net>
To: buildroot@busybox.net
Subject: [Buildroot] [Patch next v1 3/3] qt5multimedia: fix Qt5.10.1 target installation
Date: Fri, 2 Mar 2018 20:32:41 +0100	[thread overview]
Message-ID: <20180302203241.30f0256a@gmx.net> (raw)
In-Reply-To: <20180223183830.16768-4-ps.report@gmx.net>

On Fri, 23 Feb 2018 19:38:30 +0100, Peter Seiderer <ps.report@gmx.net> wrote:

> Fixes:
> 

Ups, one line of the commit message got lost...

> Signed-off-by: Peter Seiderer <ps.report@gmx.net>
> ---
>  package/qt5/qt5multimedia/qt5multimedia.mk | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/package/qt5/qt5multimedia/qt5multimedia.mk b/package/qt5/qt5multimedia/qt5multimedia.mk
> index 6120403f30..6e48fd0a09 100644
> --- a/package/qt5/qt5multimedia/qt5multimedia.mk
> +++ b/package/qt5/qt5multimedia/qt5multimedia.mk
> @@ -47,7 +47,9 @@ define QT5MULTIMEDIA_INSTALL_STAGING_CMDS
>  	$(QT5_LA_PRL_FILES_FIXUP)
>  endef
>  
> -ifeq ($(BR2_STATIC_LIBS),)
> +# since Qt5.10.1 libqgsttools was renamed to libQtMultimediaGstTools
> +# and is installed by the default target install step below
> +ifeq ($(BR2_PACKAGE_QT5_VERSION_LATEST)$(BR2_STATIC_LIBS),)

...and did add to the wrong if scope (the !BR2_STATIC_LIBS scope encloses
the mentioned default target install step too)...

Will send an update of the patchset...

Regards,
Peter

>  ifeq ($(BR2_PACKAGE_GST1_PLUGINS_BASE),y)
>  define QT5MULTIMEDIA_INSTALL_TARGET_QGSTTOOLS_LIB
>  	cp -dpf $(STAGING_DIR)/usr/lib/libqgsttools*.so.* $(TARGET_DIR)/usr/lib

      reply	other threads:[~2018-03-02 19:32 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-23 18:38 [Buildroot] [Patch next v1 0/3] Fixes for qt5: bump latest version to 5.10.1 Peter Seiderer
2018-02-23 18:38 ` [Buildroot] [Patch next v1 1/3] sqlite: add option for meta-data about tables/queries Peter Seiderer
2018-02-23 18:38 ` [Buildroot] [Patch next v1 2/3] qt5base: fix Qt5.10.1 sqlite plugin compile failure Peter Seiderer
2018-02-23 18:38 ` [Buildroot] [Patch next v1 3/3] qt5multimedia: fix Qt5.10.1 target installation Peter Seiderer
2018-03-02 19:32   ` Peter Seiderer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180302203241.30f0256a@gmx.net \
    --to=ps.report@gmx.net \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox