From mboxrd@z Thu Jan  1 00:00:00 1970
From: Yann E. MORIN <yann.morin.1998@free.fr>
Date: Sat, 3 Mar 2018 17:01:35 +0100
Subject: [Buildroot] [PATCH 1/2] support/scripts/check-uniq-files: add
 indices in format string
In-Reply-To: <20180303143620.16859-1-thomas.petazzoni@bootlin.com>
References: <20180303143620.16859-1-thomas.petazzoni@bootlin.com>
Message-ID: <20180303160135.GA20055@scaer>
List-Id: <buildroot.busybox.net>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: buildroot@busybox.net

Thomas, All,

On 2018-03-03 15:36 +0100, Thomas Petazzoni spake thusly:
> Using {} in format strings is only supported in sufficiently recent
> Python versions. Python 2.6 doesn't support this, and only format
> strings with numbered arguments: {0}, {1}, etc.
> 
> Python 2.7:
> 
> $ python -c 'print("foo {}".format(12))'
> foo 12
> $ python -c 'print("foo {0}".format(12))'
> foo 12
> 
> Python 2.6:
> 
> $ python -c 'print("foo {}".format(12))'
> Traceback (most recent call last):
>   File "<string>", line 1, in <module>
> ValueError: zero length field name in format
> $ python -c 'print("foo {0}".format(12))'
> foo 12
> 
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>

https://docs.python.org/release/2.6/library/string.html#formatstrings

Acked-by: "Yann E. MORIN" <yann.morin.1998@free.fr>

Regards,
Yann E. MORIN.

> ---
>  support/scripts/check-uniq-files | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/support/scripts/check-uniq-files b/support/scripts/check-uniq-files
> index a3d176710e..be808cce03 100755
> --- a/support/scripts/check-uniq-files
> +++ b/support/scripts/check-uniq-files
> @@ -5,7 +5,7 @@ import csv
>  import argparse
>  from collections import defaultdict
>  
> -warn = 'Warning: {} file "{}" is touched by more than one package: {}\n'
> +warn = 'Warning: {0} file "{1}" is touched by more than one package: {2}\n'
>  
>  
>  def main():
> -- 
> 2.14.3
> 

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'