Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] Fix fbgrab pixel format report
Date: Wed, 7 Mar 2018 21:25:35 +0100	[thread overview]
Message-ID: <20180307212535.3de7f012@windsurf> (raw)
In-Reply-To: <1520431971-767-1-git-send-email-timo.ketola@exertus.fi>

Hello,

On Wed,  7 Mar 2018 16:12:51 +0200, Timo Ketola wrote:
> When verbosive, fbgrab reports pixel format. Green and blue offset and
> msb_right fields are accidentally swapped there. This commit adds a patch
> which straightens them up.
> 
> Signed-off-by: Timo Ketola <timo.ketola@exertus.fi>

Thanks for this patch. One minor nit, we like the commit titles to
always follow the format:

	<package>: <description>

So perhaps here:

	fbgrab: add patch fixing pixel format report

No need to resend just for that, we can fixup when applying.

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
http://bootlin.com

  parent reply	other threads:[~2018-03-07 20:25 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-07 14:12 [Buildroot] [PATCH 1/1] Fix fbgrab pixel format report Timo Ketola
2018-03-07 15:15 ` Adrian Perez de Castro
2018-03-07 17:28   ` Timo Ketola
2018-03-07 20:22     ` Thomas Petazzoni
2018-03-07 20:25 ` Thomas Petazzoni [this message]
2018-03-08  7:32   ` Timo Ketola
  -- strict thread matches above, loose matches on Subject: below --
2018-03-07 10:59 Timo Ketola

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180307212535.3de7f012@windsurf \
    --to=thomas.petazzoni@bootlin.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox