Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH next v2 3/5] support/scripts/pkg-stats-new: add current version information
Date: Thu, 8 Mar 2018 08:48:08 +0100	[thread overview]
Message-ID: <20180308084808.5ff15bbb@windsurf> (raw)
In-Reply-To: <5aa0aaabf354_230cd1b5a053590@ultri3.mail>

Hello,

On Thu, 08 Mar 2018 00:14:51 -0300, Ricardo Martincoski wrote:

> > With this:
> > 
> >  - If the package specifies only a target version, the target version
> >    is saved.
> > 
> >  - If the package specifies only a host version, the host version is
> >    saved.
> > 
> >  - If the package specifies both a target version and a host version,
> >    the target version always wins. So the scripts doesn't handle
> >    differentiating host and target versions for the same package, but
> >    at least we are consistent in the fact that we will always report
> >    the target version.
> > 
> > How does that sound ?  
> 
> Sounds good.
> Nit: please recheck with flake8.

Will do.


> > I'm just cutting after 20 characters, and adding "..." at the end, and
> > it seems good enough to me (compared to doing a regexp to try to guess
> > if it's a git hash or not).  
> 
> OK since you are only changing the display of the version, not the string that
> will be compared to the new column.
> 
> The few version strings in the tree that are not sha1 larger than 20 are:
> 2.0.0.alpha20140727b
> kvm-unit-tests-20171020
> rel_imx_4.9.x_1.0.0_ga
> 
> For me these are OK:
> 2.0.0.alpha20140727...
> kvm-unit-tests-2017...
> rel_imx_4.9.x_1.0.0...

Yes, I'm only changing the display of the version, and I'm also adding
"..." which helps the reader understand that the version string has
been cut.

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
http://bootlin.com

  reply	other threads:[~2018-03-08  7:48 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-21 22:13 [Buildroot] [PATCH next v2 0/5] New pkg-stats script, with version information Thomas Petazzoni
2018-02-21 22:13 ` [Buildroot] [PATCH next v2 1/5] support/scripts/pkg-stats-new: rewrite in Python Thomas Petazzoni
2018-02-22  1:58   ` Ricardo Martincoski
2018-03-07 22:35     ` Thomas Petazzoni
2018-02-21 22:13 ` [Buildroot] [PATCH next v2 2/5] support/scripts/pkg-stats-new: add -n and -p options Thomas Petazzoni
2018-02-24  4:54   ` Ricardo Martincoski
2018-03-07 22:35     ` Thomas Petazzoni
2018-02-21 22:13 ` [Buildroot] [PATCH next v2 3/5] support/scripts/pkg-stats-new: add current version information Thomas Petazzoni
2018-02-26  0:47   ` Ricardo Martincoski
2018-03-07 22:25     ` Thomas Petazzoni
2018-03-08  3:14       ` Ricardo Martincoski
2018-03-08  7:48         ` Thomas Petazzoni [this message]
2018-02-21 22:13 ` [Buildroot] [PATCH next v2 4/5] support/scripts/pkg-stats-new: add latest upstream " Thomas Petazzoni
2018-02-28  3:03   ` Ricardo Martincoski
2018-03-07 22:41     ` Thomas Petazzoni
2018-03-08  9:52       ` Ricardo Martincoski
2018-03-08  9:56         ` Thomas Petazzoni
2018-03-09  2:41           ` Ricardo Martincoski
2018-03-21 20:58     ` Thomas Petazzoni
2018-03-22  3:11       ` Ricardo Martincoski
2018-03-22  7:53         ` Thomas Petazzoni
2018-03-21 21:35     ` Thomas Petazzoni
2018-03-22  3:17       ` Ricardo Martincoski
2018-03-22 10:01         ` Thomas Petazzoni
2018-02-21 22:13 ` [Buildroot] [PATCH next v2 5/5] support/scripts/pkg-stats: replace with new Python version Thomas Petazzoni
2018-02-24 17:55 ` [Buildroot] [PATCH next v2 0/5] New pkg-stats script, with version information Arnout Vandecappelle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180308084808.5ff15bbb@windsurf \
    --to=thomas.petazzoni@bootlin.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox