From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2 1/1] fbgrab: add patch fixing pixel format report
Date: Thu, 8 Mar 2018 09:30:34 +0100 [thread overview]
Message-ID: <20180308093034.002c8987@windsurf> (raw)
In-Reply-To: <1520493725-1146-1-git-send-email-timo.ketola@exertus.fi>
Hello,
On Thu, 8 Mar 2018 09:22:05 +0200, Timo Ketola wrote:
> When verbosive, fbgrab reports pixel format. Green and blue offset and
> msb_right fields are accidentally swapped there. This commit adds a patch
> which straightens them up.
>
> Upstream-Status: Submitted [Gunnar Monell <gmo@linux.nu>]
We normally put the Upstream-Status in the patch itself, i.e
>
> Signed-off-by: Timo Ketola <timo.ketola@exertus.fi>
> ---
> No changes in the payload. Only added Upstream-status (Adrian) and
> adjusted subject line (Thomas).
> ---
> package/fbgrab/0100-fix-pixfmt-report.patch | 22 ++++++++++++++++++++++
> 1 file changed, 22 insertions(+)
> create mode 100644 package/fbgrab/0100-fix-pixfmt-report.patch
>
> diff --git a/package/fbgrab/0100-fix-pixfmt-report.patch b/package/fbgrab/0100-fix-pixfmt-report.patch
> new file mode 100644
> index 0000000..18bcf96
> --- /dev/null
> +++ b/package/fbgrab/0100-fix-pixfmt-report.patch
> @@ -0,0 +1,22 @@
> +Fix pixel format report
> +
> +When fbgrab tells about the framebuffer pixel format, blue and green
> +are accidentally swapped in 'length' and 'msb_right' columns. Let's
> +order everything as RGB.
... here.
> +
> +Signed-off-by timo.ketola at exertus.fi
This Signed-off-by line doesn't follow the usual format, it should have
been:
Signed-off-by: Timo Ketola <timo.ketola@exertus.fi>
(But your patch has been applied already anyway).
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
http://bootlin.com
next prev parent reply other threads:[~2018-03-08 8:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-08 7:22 [Buildroot] [PATCH v2 1/1] fbgrab: add patch fixing pixel format report Timo Ketola
2018-03-08 8:07 ` Peter Korsgaard
2018-03-08 8:30 ` Thomas Petazzoni [this message]
2018-03-08 9:15 ` Timo Ketola
2018-03-08 9:57 ` Peter Korsgaard
2018-03-30 21:22 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180308093034.002c8987@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox