Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Seiderer <ps.report@gmx.net>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 4/4] package/rpi-firmware: improve installation of dtb files
Date: Thu, 15 Mar 2018 20:40:22 +0100	[thread overview]
Message-ID: <20180315204022.58ee68fc@gmx.net> (raw)
In-Reply-To: <1521120291-15781-4-git-send-email-martin@barkynet.com>

Hello Martin,

On Thu, 15 Mar 2018 13:24:51 +0000, Martin Bark <martin@barkynet.com> wrote:

> Don't list specific dtb files, instead install all dtb files in the same
> way as dtbo files are currently done.
> 
> Signed-off-by: Martin Bark <martin@barkynet.com>
> ---
>  package/rpi-firmware/rpi-firmware.mk | 7 +++----
>  1 file changed, 3 insertions(+), 4 deletions(-)
> 
> diff --git a/package/rpi-firmware/rpi-firmware.mk b/package/rpi-firmware/rpi-firmware.mk
> index 1ebdd96..9cc3d4a 100644
> --- a/package/rpi-firmware/rpi-firmware.mk
> +++ b/package/rpi-firmware/rpi-firmware.mk
> @@ -12,10 +12,9 @@ RPI_FIRMWARE_INSTALL_IMAGES = YES
>  
>  ifeq ($(BR2_PACKAGE_RPI_FIRMWARE_INSTALL_DTBS),y)
>  define RPI_FIRMWARE_INSTALL_DTB
> -	$(INSTALL) -D -m 0644 $(@D)/boot/bcm2708-rpi-b.dtb $(BINARIES_DIR)/rpi-firmware/bcm2708-rpi-b.dtb
> -	$(INSTALL) -D -m 0644 $(@D)/boot/bcm2708-rpi-b-plus.dtb $(BINARIES_DIR)/rpi-firmware/bcm2708-rpi-b-plus.dtb
> -	$(INSTALL) -D -m 0644 $(@D)/boot/bcm2709-rpi-2-b.dtb $(BINARIES_DIR)/rpi-firmware/bcm2709-rpi-2-b.dtb
> -	$(INSTALL) -D -m 0644 $(@D)/boot/bcm2710-rpi-3-b.dtb $(BINARIES_DIR)/rpi-firmware/bcm2710-rpi-3-b.dtb
> +	for dtb in  $(@D)/boot/*.dtb; do \
> +		$(INSTALL) -D -m 0644 $${dtb} $(BINARIES_DIR)/rpi-firmware/$${dtb##*/} || exit 1; \
> +	done

Which will install three additional dtb files (bcm2708-rpi-0-w.dtb,
bcm2708-rpi-cm.dtb and bcm2710-rpi-cm3.dtb), not a downside of the
patch, but worth mentioning....

Regards,
Peter

>  endef
>  endif
>  

  reply	other threads:[~2018-03-15 19:40 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-15 13:24 [Buildroot] [PATCH 1/4] package/rpi-firmware: bump version Martin Bark
2018-03-15 13:24 ` [Buildroot] [PATCH 2/4] configs/raspberrypi*: bump kernel version Martin Bark
2018-03-15 13:24 ` [Buildroot] [PATCH 3/4] board/raspberrypi: add support for rpi3 b+ Martin Bark
2018-03-15 13:33   ` Baruch Siach
2018-03-15 14:07     ` Martin Bark
2018-03-15 13:24 ` [Buildroot] [PATCH 4/4] package/rpi-firmware: improve installation of dtb files Martin Bark
2018-03-15 19:40   ` Peter Seiderer [this message]
2018-03-15 19:58     ` Martin Bark
2018-03-15 21:59       ` Yann E. MORIN
2018-03-15 22:40         ` Martin Bark
2018-03-16  9:32           ` Jens Maus
2018-03-16 10:52             ` Martin Bark
2018-03-16 13:07               ` Peter Korsgaard
2018-03-16 13:12               ` Jens Maus
2018-03-16 18:08                 ` Martin Bark
2018-03-15 19:28 ` [Buildroot] [PATCH 1/4] package/rpi-firmware: bump version Peter Seiderer
2018-03-15 20:23   ` Martin Bark

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180315204022.58ee68fc@gmx.net \
    --to=ps.report@gmx.net \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox