From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v5 3/5] gstreamer1 packages: explicitly disable introspection
Date: Sun, 18 Mar 2018 20:21:36 +0100 [thread overview]
Message-ID: <20180318192136.GH2478@scaer> (raw)
In-Reply-To: <20180318190131.21404-4-aduskett@gmail.com>
Adma, All,
On 2018-03-18 15:01 -0400, Adam Duskett spake thusly:
> To get GStreamer ready for introspection, we must first explicitly
> disable gstreamer1, plugins base and plugins bad from using introspection.
> If not, adding the gobject-introspection will result in these packages
> failing to build because setting the _GIR_EXTRA_LIBS_PATH variable is required.
>
> The other gstreamer1 packages do not require setting the _GIR_EXTRA_LIBS_PATH
> variable.
>
> Signed-off-by: Adam Duskett <aduskett@gmail.com>
If there are other packages that may support GIR, we can add that option
later on as we discover them.
Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Regards,
Yann E. MORIN.
> ---
> Changes v1 -> v4:
> - Add patch to series.
> - Change TARGET_MAKE_ENV += GIR_EXTRA_LIBS_PATH to
> PACKAGE_GIR_EXTRA_LIBS_PATH.
>
> Changes v4 -> v5:
> - Change --enable-introspection=no to --disable-introspection (Yann)
>
> package/gstreamer1/gst1-plugins-bad/gst1-plugins-bad.mk | 3 ++-
> package/gstreamer1/gst1-plugins-base/gst1-plugins-base.mk | 3 ++-
> package/gstreamer1/gstreamer1/gstreamer1.mk | 1 +
> 3 files changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/package/gstreamer1/gst1-plugins-bad/gst1-plugins-bad.mk b/package/gstreamer1/gst1-plugins-bad/gst1-plugins-bad.mk
> index 83cb94be81..a4adc0e49e 100644
> --- a/package/gstreamer1/gst1-plugins-bad/gst1-plugins-bad.mk
> +++ b/package/gstreamer1/gst1-plugins-bad/gst1-plugins-bad.mk
> @@ -21,7 +21,8 @@ GST1_PLUGINS_BAD_CONF_OPTS = \
> --disable-winks \
> --disable-android_media \
> --disable-apple_media \
> - --disable-acm
> + --disable-acm \
> + --disable-introspection
>
> # Options which require currently unpackaged libraries
> GST1_PLUGINS_BAD_CONF_OPTS += \
> diff --git a/package/gstreamer1/gst1-plugins-base/gst1-plugins-base.mk b/package/gstreamer1/gst1-plugins-base/gst1-plugins-base.mk
> index 10361ee3c6..2d183ce572 100644
> --- a/package/gstreamer1/gst1-plugins-base/gst1-plugins-base.mk
> +++ b/package/gstreamer1/gst1-plugins-base/gst1-plugins-base.mk
> @@ -14,7 +14,8 @@ GST1_PLUGINS_BASE_LICENSE = LGPL-2.0+, LGPL-2.1+
> # gio_unix_2_0 is only used for tests
> GST1_PLUGINS_BASE_CONF_OPTS = \
> --disable-examples \
> - --disable-valgrind
> + --disable-valgrind \
> + --disable-introspection
>
> # Options which require currently unpackaged libraries
> GST1_PLUGINS_BASE_CONF_OPTS += \
> diff --git a/package/gstreamer1/gstreamer1/gstreamer1.mk b/package/gstreamer1/gstreamer1/gstreamer1.mk
> index ea9f29a4f3..b00057a374 100644
> --- a/package/gstreamer1/gstreamer1/gstreamer1.mk
> +++ b/package/gstreamer1/gstreamer1/gstreamer1.mk
> @@ -17,6 +17,7 @@ GSTREAMER1_CONF_OPTS = \
> --disable-failing-tests \
> --disable-valgrind \
> --disable-benchmarks \
> + --disable-introspection \
> $(if $(BR2_PACKAGE_GSTREAMER1_CHECK),,--disable-check) \
> $(if $(BR2_PACKAGE_GSTREAMER1_TRACE),,--disable-trace) \
> $(if $(BR2_PACKAGE_GSTREAMER1_PARSE),,--disable-parse) \
> --
> 2.14.3
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
next prev parent reply other threads:[~2018-03-18 19:21 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-18 19:01 [Buildroot] [PATCH v5 0/5] gobject-introspection: new series Adam Duskett
2018-03-18 19:01 ` [Buildroot] [PATCH v5 1/5] qemu-host: remove support for some powerpc processors Adam Duskett
2018-03-18 19:16 ` Yann E. MORIN
2018-03-26 19:54 ` Thomas Petazzoni
2018-03-18 19:01 ` [Buildroot] [PATCH v5 2/5] qemu: add qemu_user_opts Adam Duskett
2018-03-18 19:18 ` Yann E. MORIN
2018-03-18 19:21 ` Adam Duskett
2018-03-18 19:01 ` [Buildroot] [PATCH v5 3/5] gstreamer1 packages: explicitly disable introspection Adam Duskett
2018-03-18 19:21 ` Yann E. MORIN [this message]
2018-03-18 19:01 ` [Buildroot] [PATCH v5 1/1] gobject-introspection: new package Adam Duskett
2018-03-20 17:39 ` Matthew Weber
2018-03-23 18:08 ` Arnout Vandecappelle
2018-03-18 19:01 ` [Buildroot] [PATCH v5 5/5] gstreamer1 packages: add support for introspection Adam Duskett
2018-03-20 16:12 ` [Buildroot] [PATCH v5 0/5] gobject-introspection: new series Matthew Weber
2018-03-21 13:44 ` Adam Duskett
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180318192136.GH2478@scaer \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox