From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [V3 2/2] dropbear: unbundle libtomath & libtomcrypt
Date: Wed, 21 Mar 2018 21:13:10 +0100 [thread overview]
Message-ID: <20180321211310.50f6410c@windsurf> (raw)
In-Reply-To: <20180321170413.74jd5vq4ygcgbewp@tarshish>
Hello,
On Wed, 21 Mar 2018 19:04:13 +0200, Baruch Siach wrote:
> > ifeq ($(BR2_PACKAGE_DROPBEAR_SMALL),y)
> > -DROPBEAR_CONF_OPTS += --disable-zlib
> > +DROPBEAR_CONF_OPTS += --disable-zlib --enable-bundled-libtom
> > else
> > DROPBEAR_POST_EXTRACT_HOOKS += DROPBEAR_BUILD_FEATURED
> > -DROPBEAR_DEPENDENCIES += zlib
> > +DROPBEAR_DEPENDENCIES += zlib libtomcrypt
> > +DROPBEAR_CONF_OPTS += --disable-bundled-libtom
>
> As I said on v2[1] I think that unbundling static libraries is not worth it.
>
> [1] http://patchwork.ozlabs.org/comment/1879448/
I am not sure why you say that. In general, I think unbundling is good.
Why should we make an exception here ?
Thomas
--
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2018-03-21 20:13 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-21 16:03 [Buildroot] [V3 1/2] dropbear: bump to version 2018.76 Francois Perrad
2018-03-21 16:03 ` [Buildroot] [V3 2/2] dropbear: unbundle libtomath & libtomcrypt Francois Perrad
2018-03-21 17:04 ` Baruch Siach
2018-03-21 20:13 ` Thomas Petazzoni [this message]
2018-03-21 20:16 ` Baruch Siach
2018-03-21 20:22 ` Thomas Petazzoni
2018-03-22 5:36 ` Baruch Siach
2018-03-23 4:15 ` François Perrad
2018-03-23 6:16 ` Baruch Siach
2018-03-26 20:18 ` [Buildroot] [V3 1/2] dropbear: bump to version 2018.76 Thomas Petazzoni
2018-03-28 7:57 ` François Perrad
2018-03-28 8:01 ` Thomas Petazzoni
2018-03-28 8:42 ` François Perrad
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180321211310.50f6410c@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox