Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Seiderer <ps.report@gmx.net>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2 2/8] gst-plugins-{base, good, bad, ugly}: bump to 1.14
Date: Thu, 22 Mar 2018 13:30:23 +0100	[thread overview]
Message-ID: <20180322133023.683b3225@gmx.net> (raw)
In-Reply-To: <CAFSsvmo9t+B=ardFmaFSuN3+9PohWjiK5Bm-orcLCG8dUJjZgg@mail.gmail.com>

Hello Adam,


> >>  config BR2_PACKAGE_GST1_PLUGINS_BAD_LIB_OPENGL_WAYLAND
> >>       bool "wayland"
> >>       default y  
> >
> > ...not enough removed, the wayland part also moved to gst1-plugins-base
> > (same for Config.in wayland part)...
> >  
> Not entirely! There is --enable-wayland now in both base AND bad!
> 

So your commit log lies ;-), wayland did not move from bad to base....

> >> Changes:
> >>
> >> Add the following to gst1-plugins-base and remove them from plugins-bad:
> >>  - opengl
> >>  - gles2
> >>  - glx
> >>  - egl
> >>  - x11
> >>  - wayland

I think there is a difference, the bad/wayland option enables extra gstreamer
plugins/elements, the base/wayland opton enables no extra plugins/elements but
enables wayland support in the qt/gtk plugins (did not look further if it
results only in wayland support in some elements or extra elements in the same
plugin library), in case it enables only wayland support, I think no
user visible option is needed (if a user visible option is needed there is
definitely a change in option name and help text needed)

> Adam
> 

Please do not miss the comment/suggestion below:

> >> -config BR2_PACKAGE_GST1_PLUGINS_BAD_PLUGIN_AUDIOMIXER
> >> -     bool "audiomixer"
> >> -     help
> >> -       Audio mixer plugin
> >> -  
> >
> > ..forgot to re-add this one to gst1-plugins-base/Config.in....
> >
> > Regards,
> > Peter

Regards,
Peter

  reply	other threads:[~2018-03-22 12:30 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-21 13:41 [Buildroot] [PATCH v2 1/8] gstreamer1: bump to 1.14 Adam Duskett
2018-03-21 13:41 ` [Buildroot] [PATCH v2 2/8] gst-plugins-{base, good, bad, ugly}: " Adam Duskett
2018-03-21 19:09   ` Peter Seiderer
2018-03-21 22:02     ` Adam Duskett
2018-03-22 12:30       ` Peter Seiderer [this message]
2018-03-22  8:35   ` Martin Kepplinger
2018-03-21 13:41 ` [Buildroot] [PATCH v2 3/8] gst-omx: " Adam Duskett
2018-03-21 13:41 ` [Buildroot] [PATCH v2 4/8] gst1-rtsp-server: " Adam Duskett
2018-03-21 13:41 ` [Buildroot] [PATCH v2 5/8] gst1-vaapi: " Adam Duskett
2018-03-21 13:41 ` [Buildroot] [PATCH v2 6/8] gst1-libav: " Adam Duskett
2018-03-21 13:41 ` [Buildroot] [PATCH v2 7/8] gst1-validate: " Adam Duskett
2018-03-21 13:41 ` [Buildroot] [PATCH v2 8/8] gst1-imx: add hash for license file Adam Duskett

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180322133023.683b3225@gmx.net \
    --to=ps.report@gmx.net \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox