Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] safeclib: fix build without wchar and host-doxygen
Date: Sun, 25 Mar 2018 23:25:01 +0200	[thread overview]
Message-ID: <20180325232501.5e846351@windsurf> (raw)
In-Reply-To: <20180315193711.11437-1-fontaine.fabrice@gmail.com>

Hello,

On Thu, 15 Mar 2018 20:37:11 +0100, Fabrice Fontaine wrote:

> diff --git a/package/safeclib/0001-Add-disable-doc-option.patch b/package/safeclib/0001-Add-disable-doc-option.patch
> new file mode 100644
> index 0000000000..67c48906f3
> --- /dev/null
> +++ b/package/safeclib/0001-Add-disable-doc-option.patch
> @@ -0,0 +1,58 @@
> +From 0d56b6327f6b652511c3e4c72382f4dc4d194e10 Mon Sep 17 00:00:00 2001
> +From: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> +Date: Thu, 15 Mar 2018 20:12:28 +0100
> +Subject: [PATCH] Add --disable-doc option
> +
> +This option allows the user to disable man pages even if pod2man and
> +doxygen programs are found
> +
> +Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>

Since it has been applied upstream now, I've added a reference to the
upstream commit here.

> ++AC_ARG_ENABLE(doc,
> ++	AS_HELP_STRING([--disable-doc],
> ++	               [disable documentation @<:@default=no@:>@]),
> ++	[case "${enableval}" in
> ++	yes) enable_doc=true ;;
> ++	no)  enable_doc=false ;;
> ++	*)   AC_MSG_ERROR([bad value ${enableval} for --enable-doc]) ;;

I haven't seen many configure.ac scripts that do this. Most simply do:

	enable_doc=${enableval}

and that's it.

But OK, it's been accepted upstream, so I don't care :)

Patch applied to master. Thanks!

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com

      reply	other threads:[~2018-03-25 21:25 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-15 19:37 [Buildroot] [PATCH 1/1] safeclib: fix build without wchar and host-doxygen Fabrice Fontaine
2018-03-25 21:25 ` Thomas Petazzoni [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180325232501.5e846351@windsurf \
    --to=thomas.petazzoni@bootlin.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox