Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] Makefile: fix build break in sdk target
Date: Mon, 26 Mar 2018 11:16:13 +0200	[thread overview]
Message-ID: <20180326111613.002ee281@windsurf> (raw)
In-Reply-To: <20180326072332.30808-1-chemobejk@gmail.com>

Hello,

On Mon, 26 Mar 2018 10:23:32 +0300, Stefan Becker wrote:
> After commit 6729050f3a49dba42d2d881d31dbefd6b82b8dad nothing creates
> $(HOST_DIR)/share/buildroot anymore, causing sdk to fail with:
> 
>  /bin/bash: .../output/host/share/buildroot/sdk-location: No such file or directory
> 
> Add creation of that directory to the "sdk" build steps itself.
> 
> Signed-off-by: Stefan Becker <chemobejk@gmail.com>
> ---
>  Makefile | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Makefile b/Makefile
> index a3a9d290d9..9e2402d7d9 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -574,6 +574,7 @@ sdk: world
>  	$(TOPDIR)/support/scripts/fix-rpath host
>  	$(TOPDIR)/support/scripts/fix-rpath staging
>  	$(INSTALL) -m 755 $(TOPDIR)/support/misc/relocate-sdk.sh $(HOST_DIR)/relocate-sdk.sh
> +	mkdir -p $(HOST_DIR)/share/buildroot

While this is OK, I am still not sure to understand why you are seeing
this problem. My commit 6729050f3a49dba42d2d881d31dbefd6b82b8dad moved
the creation of the $(HOST_DIR)/share/buildroot folder from a
dependency of the toolchain package, to a post-install staging hook of
the toolchain package.

But in both cases, the logic should be executed way before
the sdk target is called.

So, I'm puzzled.

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com

  parent reply	other threads:[~2018-03-26  9:16 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20180326072332.30808-1-chemobejk@gmail.com>
2018-03-26  8:50 ` [Buildroot] [PATCH 1/1] Makefile: fix build break in sdk target Peter Korsgaard
2018-03-26  9:16 ` Thomas Petazzoni [this message]
     [not found]   ` <CAOJ2eMcc6TuND32UFt_TLQA1atMNGNrPshqjREWgo4VO71iapg@mail.gmail.com>
2018-03-26 12:08     ` Stefan Becker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180326111613.002ee281@windsurf \
    --to=thomas.petazzoni@bootlin.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox