From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [V4 1/2] dropbear: bump to version 2018.76
Date: Wed, 28 Mar 2018 16:42:24 +0200 [thread overview]
Message-ID: <20180328164224.656e7c04@windsurf> (raw)
In-Reply-To: <CAB0FRsst0X_avRh0_AkSo=zTBnkHCKCiL6_dL9g0PCoP57syQA@mail.gmail.com>
Hello,
On Wed, 28 Mar 2018 16:41:03 +0200, Fran?ois Perrad wrote:
> > On Wed, 28 Mar 2018 10:38:26 +0200, Francois Perrad wrote:
> >
> > > +define DROPBEAR_SVR_PASSWORD_AUTH
> > > + echo '#if !HAVE_CRYPT' >>
> > $(@D)/localoptions.h
> > > + echo '#define DROPBEAR_SVR_PASSWORD_AUTH 0' >>
> > $(@D)/localoptions.h
> > > + echo '#endif' >>
> > $(@D)/localoptions.h
> > > endef
> >
> > Since this is really a bug in dropbear, shouldn't this be handled by a
> > patch, which gets submitted upstream ?
> >
> >
> The average Dropbear user puts only #define in localoptions.h
> BR supports various toolchains with many differences, so we need some logic
> in localoptions.h
> There is no upstream bug.
I think there's an upstream bug if the configure script detects the
presence/absence of crypt(), but then doesn't use this information to
disable features that require crypt() when it's not available.
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2018-03-28 14:42 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-28 8:38 [Buildroot] [V4 1/2] dropbear: bump to version 2018.76 Francois Perrad
2018-03-28 8:38 ` [Buildroot] [V4 2/2] dropbear: unbundle libtomath & libtomcrypt Francois Perrad
2018-04-28 15:50 ` Thomas Petazzoni
2018-03-28 11:51 ` [Buildroot] [V4 1/2] dropbear: bump to version 2018.76 Thomas Petazzoni
2018-03-28 14:41 ` François Perrad
2018-03-28 14:42 ` Thomas Petazzoni [this message]
2018-04-28 15:49 ` Thomas Petazzoni
2018-08-27 9:37 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180328164224.656e7c04@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox