From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 2/2] package/kodi: remove imx support
Date: Sat, 31 Mar 2018 23:08:52 +0200 [thread overview]
Message-ID: <20180331230852.169d6da8@windsurf> (raw)
In-Reply-To: <20180304150606.32748-2-bernd.kuhls@t-online.de>
Hello,
On Sun, 4 Mar 2018 16:06:06 +0100, Bernd Kuhls wrote:
> https://git.buildroot.net/buildroot/commit/?id=266208972192f1e0869f89d7be941de6294a810a
> broke imx support in Kodi because previously the G2D libraries were
> part of the imx-gpu-viv package:
>
> CMake Error at /usr/share/cmake-3.7/Modules/FindPackageHandleStandardArgs.cmake:138 (message):
> Could NOT find IMX (missing: G2D_LIBRARY)
>
> Adjusting the Kodi package to use the imx-gpu-g2d as well still does
> not provide a working build:
>
> /home/buildroot/br4/output/build/kodi-17.6-Krypton/xbmc/linux/imx/IMX.cpp: In member function 'void CIMX::Deinitialize()':
> /home/buildroot/br4/output/build/kodi-17.6-Krypton/xbmc/linux/imx/IMX.cpp:79:21: error: 'DCIC_IOC_STOP_VSYNC' was not declared in this scope
> ioctl(m_fddcic, DCIC_IOC_STOP_VSYNC, 0);
> ^~~~~~~~~~~~~~~~~~~
> /home/buildroot/br4/output/build/kodi-17.6-Krypton/xbmc/linux/imx/IMX.cpp: In member function 'bool CIMX::UpdateDCIC()':
> /home/buildroot/br4/output/build/kodi-17.6-Krypton/xbmc/linux/imx/IMX.cpp:109:19: error: 'DCIC_IOC_STOP_VSYNC' was not declared in this scope
> ioctl(m_fddcic, DCIC_IOC_STOP_VSYNC, 0);
> ^~~~~~~~~~~~~~~~~~~
> /home/buildroot/br4/output/build/kodi-17.6-Krypton/xbmc/linux/imx/IMX.cpp:115:21: error: 'DCIC_IOC_START_VSYNC' was not declared in this scope
> ioctl(m_fddcic, DCIC_IOC_START_VSYNC, 0);
> ^~~~~~~~~~~~~~~~~~~~
> /home/buildroot/br4/output/build/kodi-17.6-Krypton/xbmc/linux/imx/IMX.cpp: In member function 'virtual void CIMX::Process()':
> /home/buildroot/br4/output/build/kodi-17.6-Krypton/xbmc/linux/imx/IMX.cpp:125:19: error: 'DCIC_IOC_START_VSYNC' was not declared in this scope
> ioctl(m_fddcic, DCIC_IOC_START_VSYNC, 0);
> ^~~~~~~~~~~~~~~~~~~~
> /home/buildroot/br4/output/build/kodi-17.6-Krypton/xbmc/linux/imx/IMX.cpp:131:19: error: 'DCIC_IOC_STOP_VSYNC' was not declared in this scope
> ioctl(m_fddcic, DCIC_IOC_STOP_VSYNC, 0);
> ^~~~~~~~~~~~~~~~~~~
>
> Although it might be possible to fix these bugs with something like
>
> #define DCIC_IOC_CONFIG_DCIC _IO('D', 12)
> #define DCIC_IOC_START_VSYNC _IO('D', 15)
> #define DCIC_IOC_STOP_VSYNC _IO('D', 16)
>
> as done in
> https://raw.githubusercontent.com/LibreELEC/LibreELEC.tv/libreelec-7.0/projects/imx6/patches/kodi/imx6-jarvis.patch
>
> we would still try to ride a dead horse. The upcoming Kodi version
> 18.0-Leia will remove imx support completely, see upstream PR 12990.
>
> Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
> ---
> package/kodi/kodi.mk | 6 ------
> 1 file changed, 6 deletions(-)
I've kept an unconditional and explicit -DENABLE_IMX=OFF in
KODI_CONF_OPTS, and applied. Thanks!
Thomas
--
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2018-03-31 21:08 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-04 15:06 [Buildroot] [PATCH 1/2] package/freescale-imx: Remove imx6s from has_vpu list Bernd Kuhls
2018-03-04 15:06 ` [Buildroot] [PATCH 2/2] package/kodi: remove imx support Bernd Kuhls
2018-03-05 8:54 ` Gary Bisson
2018-03-31 21:08 ` Thomas Petazzoni [this message]
2018-04-08 15:07 ` Peter Korsgaard
2018-03-05 8:35 ` [Buildroot] [PATCH 1/2] package/freescale-imx: Remove imx6s from has_vpu list Gary Bisson
2018-03-31 21:08 ` Thomas Petazzoni
2018-04-08 15:07 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180331230852.169d6da8@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox