From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2 01/37] check-package: prepare to extend to other directories
Date: Sun, 1 Apr 2018 08:02:45 +0200 [thread overview]
Message-ID: <20180401080245.1e7988a7@windsurf> (raw)
In-Reply-To: <20180401050850.5701-2-ricardo.martincoski@gmail.com>
Hello,
On Sun, 1 Apr 2018 02:08:14 -0300, Ricardo Martincoski wrote:
> Currently the script only checks files inside the package/ directory.
> Upcoming patches will enable it for other directories.
>
> In order to reliably test for file names, i.e. the Config.in in the base
> directory, normalize the path of files to check to a relative path to
> the base directory.
>
> Rename the variable that holds the compiled regexp to better represent
> its content and rearrange how it is declared to make easy to later add
> new directories to check. As a consequence the files that declare
> package infra types would not be ignored anymore, so create a new
> variable to list the files intree to be ignored during the check. The
> same variable will be used by upcoming patches to ignore other files.
> Ignore pkg-*.mk and doc-asciidoc.mk since they are package infra files.
>
> In order to not produce weird results when used for files outside the
> tree (i.e. in a private br2-external) add an explicit command line
> option (-b) that bypasses any checks that would make a file be ignored
> by the path that contains it.
> When in this out-of-tree mode, the user is responsible for providing a
> list of files to check that do not contain files the script does not
> understand, e.g. package infra files.
>
> As a result of this patch, besides the known use:
> $ ./utils/check-package package/new-package/*
> someone with the utils/ directory in the path can now also run:
> $ cd package/new-package/
> $ check-package *
> or
> $ check-package -b /path/to/br2-ext-tree/package/staging-package/*
>
> Signed-off-by: Ricardo Martincoski <ricardo.martincoski@gmail.com>
> ---
> Changes v1 -> v2:
> - no changes
> ---
> utils/check-package | 32 +++++++++++++++++++++++++++-----
> 1 file changed, 27 insertions(+), 5 deletions(-)
Applied to master, thanks.
Thomas
--
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2018-04-01 6:02 UTC|newest]
Thread overview: 124+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-31 2:22 [Buildroot] [PATCH 00/36] check-package: allow to check other directories v1 Ricardo Martincoski
2018-03-31 2:22 ` [Buildroot] [PATCH 01/36] check-package: prepare to extend to other directories Ricardo Martincoski
2018-03-31 2:22 ` [Buildroot] [PATCH 02/36] check-package: enable for arch/ and system/ Ricardo Martincoski
2018-03-31 2:22 ` [Buildroot] [PATCH 03/36] boot/*/*.mk: fix code style Ricardo Martincoski
2018-03-31 2:22 ` [Buildroot] [PATCH 04/36] check-package: enable for boot/ Ricardo Martincoski
2018-03-31 2:22 ` [Buildroot] [PATCH 05/36] fs/yaffs2: fix code style Ricardo Martincoski
2018-03-31 2:22 ` [Buildroot] [PATCH 06/36] fs/ubi: use namespace for internal variable Ricardo Martincoski
2018-03-31 2:22 ` [Buildroot] [PATCH 07/36] fs/*/*.mk: fix code style Ricardo Martincoski
2018-03-31 2:22 ` [Buildroot] [PATCH 08/36] check-package: enable for fs/ Ricardo Martincoski
2018-03-31 2:22 ` [Buildroot] [PATCH 09/36] linux/linux-ext-*.mk: fit file header into one line Ricardo Martincoski
2018-03-31 2:22 ` [Buildroot] [PATCH 10/36] linux/linux*.mk: fix code style Ricardo Martincoski
2018-03-31 2:22 ` [Buildroot] [PATCH 11/36] linux/linux.mk: use namespace for internal variables Ricardo Martincoski
2018-03-31 6:20 ` Thomas Petazzoni
2018-04-01 4:12 ` Ricardo Martincoski
2018-03-31 2:22 ` [Buildroot] [PATCH 12/36] check-package: enable for linux/ Ricardo Martincoski
2018-03-31 2:22 ` [Buildroot] [PATCH 13/36] toolchain/wrapper: fix code style Ricardo Martincoski
2018-03-31 2:22 ` [Buildroot] [PATCH 14/36] toolchain/toolchain.mk: " Ricardo Martincoski
2018-03-31 6:21 ` Thomas Petazzoni
2018-04-01 4:13 ` Ricardo Martincoski
2018-03-31 2:22 ` [Buildroot] [PATCH 15/36] check-package: enable for toolchain/ Ricardo Martincoski
2018-03-31 6:38 ` Thomas Petazzoni
2018-03-31 8:48 ` Arnout Vandecappelle
2018-04-01 4:29 ` Ricardo Martincoski
2018-04-01 4:16 ` Ricardo Martincoski
2018-03-31 2:22 ` [Buildroot] [PATCH 16/36] check-package: enable for Config.in* in base dir Ricardo Martincoski
2018-03-31 2:22 ` [Buildroot] [PATCH 17/36] docs/manual: add check-package to "Tips and tricks" Ricardo Martincoski
2018-03-31 2:22 ` [Buildroot] [PATCH 18/36] */Config.in*: remove consecutive empty lines Ricardo Martincoski
2018-03-31 2:22 ` [Buildroot] [PATCH 19/36] Config.in*: fix attributes order Ricardo Martincoski
2018-03-31 2:22 ` [Buildroot] [PATCH 20/36] arch/Config.in*: " Ricardo Martincoski
2018-03-31 2:22 ` [Buildroot] [PATCH 21/36] boot/*/Config.in: " Ricardo Martincoski
2018-03-31 2:22 ` [Buildroot] [PATCH 22/36] fs/*/Config.in: " Ricardo Martincoski
2018-03-31 2:22 ` [Buildroot] [PATCH 23/36] package/*/Config.in: " Ricardo Martincoski
2018-03-31 2:22 ` [Buildroot] [PATCH 24/36] toolchain/*/Config.in: " Ricardo Martincoski
2018-03-31 2:22 ` [Buildroot] [PATCH 25/36] Config.in*: re-wrap help text Ricardo Martincoski
2018-03-31 2:22 ` [Buildroot] [PATCH 26/36] arch/Config.in*: " Ricardo Martincoski
2018-03-31 2:22 ` [Buildroot] [PATCH 27/36] boot/*/Config.in: " Ricardo Martincoski
2018-03-31 2:22 ` [Buildroot] [PATCH 28/36] fs/*/Config.in: " Ricardo Martincoski
2018-03-31 2:22 ` [Buildroot] [PATCH 29/36] linux/Config.*: " Ricardo Martincoski
2018-03-31 2:22 ` [Buildroot] [PATCH 30/36] system/Config.in: " Ricardo Martincoski
2018-03-31 2:22 ` [Buildroot] [PATCH 31/36] toolchain/{*/Config.in, *.in}: " Ricardo Martincoski
2018-03-31 2:22 ` [Buildroot] [PATCH 33/36] package/*/Config.in: " Ricardo Martincoski
2018-03-31 2:22 ` [Buildroot] [PATCH 34/36] scanpypi: generate help text compliant to check-package Ricardo Martincoski
2018-03-31 2:23 ` [Buildroot] [PATCH 35/36] utils/checkpackagelib: exclude four files from Config.in indentation check Ricardo Martincoski
2018-03-31 2:23 ` [Buildroot] [PATCH 36/36] .gitlab-ci.yml: extend check-package test to Config.* files Ricardo Martincoski
2018-04-01 5:08 ` [Buildroot] [PATCH v2 00/37] check-package: allow to check other directories v2 Ricardo Martincoski
2018-04-01 5:08 ` [Buildroot] [PATCH v2 01/37] check-package: prepare to extend to other directories Ricardo Martincoski
2018-04-01 6:02 ` Thomas Petazzoni [this message]
2018-04-01 5:08 ` [Buildroot] [PATCH v2 02/37] check-package: enable for arch/ and system/ Ricardo Martincoski
2018-04-01 6:03 ` Thomas Petazzoni
2018-04-01 5:08 ` [Buildroot] [PATCH v2 03/37] boot/*/*.mk: fix code style Ricardo Martincoski
2018-04-01 5:55 ` Thomas Petazzoni
2018-04-01 5:08 ` [Buildroot] [PATCH v2 04/37] check-package: enable for boot/ Ricardo Martincoski
2018-04-01 6:49 ` Thomas Petazzoni
2018-04-01 5:08 ` [Buildroot] [PATCH v2 05/37] fs/yaffs2: fix code style Ricardo Martincoski
2018-04-01 5:55 ` Thomas Petazzoni
2018-04-01 5:08 ` [Buildroot] [PATCH v2 06/37] fs/ubi: use namespace for internal variable Ricardo Martincoski
2018-04-01 6:42 ` Thomas Petazzoni
2018-04-01 5:08 ` [Buildroot] [PATCH v2 07/37] fs/*/*.mk: fix code style Ricardo Martincoski
2018-04-01 6:42 ` Thomas Petazzoni
2018-04-01 5:08 ` [Buildroot] [PATCH v2 08/37] check-package: enable for fs/ Ricardo Martincoski
2018-04-01 6:53 ` Thomas Petazzoni
2018-04-01 5:08 ` [Buildroot] [PATCH v2 09/37] linux/linux-ext-*.mk: fit file header into one line Ricardo Martincoski
2018-04-01 6:46 ` Thomas Petazzoni
2018-04-01 5:08 ` [Buildroot] [PATCH v2 10/37] linux/linux*.mk: fix code style Ricardo Martincoski
2018-04-01 6:46 ` Thomas Petazzoni
2018-04-01 5:08 ` [Buildroot] [PATCH v2 11/37] linux/linux.mk: use namespace for internal variables Ricardo Martincoski
2018-04-01 6:46 ` Thomas Petazzoni
2018-04-01 5:08 ` [Buildroot] [PATCH v2 12/37] check-package: enable for linux/ Ricardo Martincoski
2018-04-01 7:08 ` Thomas Petazzoni
2018-04-01 5:08 ` [Buildroot] [PATCH v2 13/37] toolchain: merge toolchain-common.in to Config.in Ricardo Martincoski
2018-04-01 6:46 ` Thomas Petazzoni
2018-04-01 5:08 ` [Buildroot] [PATCH v2 14/37] toolchain/wrapper: fix code style Ricardo Martincoski
2018-04-01 6:46 ` Thomas Petazzoni
2018-04-01 5:08 ` [Buildroot] [PATCH v2 15/37] toolchain/toolchain.mk: " Ricardo Martincoski
2018-04-01 6:47 ` Thomas Petazzoni
2018-04-01 5:08 ` [Buildroot] [PATCH v2 16/37] check-package: enable for toolchain/ Ricardo Martincoski
2018-04-01 7:10 ` Thomas Petazzoni
2018-04-01 5:08 ` [Buildroot] [PATCH v2 17/37] check-package: enable for Config.in* in base dir Ricardo Martincoski
2018-04-01 7:12 ` Thomas Petazzoni
2018-04-01 5:08 ` [Buildroot] [PATCH v2 18/37] docs/manual: add check-package to "Tips and tricks" Ricardo Martincoski
2018-04-01 7:16 ` Thomas Petazzoni
2018-04-01 20:53 ` Ricardo Martincoski
2018-04-01 21:03 ` Thomas Petazzoni
2018-04-01 21:51 ` Ricardo Martincoski
2018-04-01 22:31 ` [Buildroot] [PATCH v3 1/1] " Ricardo Martincoski
2018-04-01 22:43 ` Thomas Petazzoni
2018-04-01 5:08 ` [Buildroot] [PATCH v2 19/37] */Config.in*: remove consecutive empty lines Ricardo Martincoski
2018-04-01 6:48 ` Thomas Petazzoni
2018-04-01 5:08 ` [Buildroot] [PATCH v2 20/37] Config.in*: fix attributes order Ricardo Martincoski
2018-04-01 7:12 ` Thomas Petazzoni
2018-04-01 5:08 ` [Buildroot] [PATCH v2 21/37] arch/Config.in*: " Ricardo Martincoski
2018-04-01 6:02 ` Thomas Petazzoni
2018-04-01 5:08 ` [Buildroot] [PATCH v2 22/37] boot/*/Config.in: " Ricardo Martincoski
2018-04-01 6:07 ` Thomas Petazzoni
2018-04-01 5:08 ` [Buildroot] [PATCH v2 23/37] fs/*/Config.in: " Ricardo Martincoski
2018-04-01 6:53 ` Thomas Petazzoni
2018-04-01 5:08 ` [Buildroot] [PATCH v2 24/37] package/*/Config.in: " Ricardo Martincoski
2018-04-01 8:15 ` Thomas Petazzoni
2018-04-01 5:08 ` [Buildroot] [PATCH v2 25/37] toolchain/*/Config.in: " Ricardo Martincoski
2018-04-01 7:09 ` Thomas Petazzoni
2018-04-01 5:08 ` [Buildroot] [PATCH v2 26/37] Config.in*: re-wrap help text Ricardo Martincoski
2018-04-01 7:12 ` Thomas Petazzoni
2018-04-01 5:08 ` [Buildroot] [PATCH v2 27/37] arch/Config.in*: " Ricardo Martincoski
2018-04-01 6:02 ` Thomas Petazzoni
2018-04-01 5:08 ` [Buildroot] [PATCH v2 28/37] boot/*/Config.in: " Ricardo Martincoski
2018-04-01 6:07 ` Thomas Petazzoni
2018-04-01 5:08 ` [Buildroot] [PATCH v2 29/37] fs/*/Config.in: " Ricardo Martincoski
2018-04-01 6:53 ` Thomas Petazzoni
2018-04-01 5:08 ` [Buildroot] [PATCH v2 30/37] linux/Config.*: " Ricardo Martincoski
2018-04-01 7:08 ` Thomas Petazzoni
2018-04-01 5:08 ` [Buildroot] [PATCH v2 31/37] system/Config.in: " Ricardo Martincoski
2018-04-01 6:02 ` Thomas Petazzoni
2018-04-01 5:08 ` [Buildroot] [PATCH v2 32/37] toolchain/*/Config.in: " Ricardo Martincoski
2018-04-01 7:09 ` Thomas Petazzoni
2018-04-01 5:08 ` [Buildroot] [PATCH v2 33/37] qemu/Config.in.host: fix overindented depends on Ricardo Martincoski
2018-04-01 7:10 ` Thomas Petazzoni
2018-04-01 5:08 ` [Buildroot] [PATCH v2 34/37] package/*/Config.in: re-wrap help text Ricardo Martincoski
2018-04-01 8:15 ` Thomas Petazzoni
2018-04-01 5:08 ` [Buildroot] [PATCH v2 35/37] scanpypi: generate help text compliant to check-package Ricardo Martincoski
2018-04-01 8:16 ` Thomas Petazzoni
2018-04-01 5:08 ` [Buildroot] [PATCH v2 36/37] utils/checkpackagelib: exclude four files from Config.in indentation check Ricardo Martincoski
2018-04-01 8:16 ` Thomas Petazzoni
2018-04-01 5:08 ` [Buildroot] [PATCH v2 37/37] .gitlab-ci.yml: extend check-package test to Config.* files Ricardo Martincoski
2018-04-01 8:17 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180401080245.1e7988a7@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox