From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] toolchain-wrapper: use -ffp-contract=off on MIPS Xburst for gcc >= 4.6
Date: Sun, 1 Apr 2018 16:23:57 +0200 [thread overview]
Message-ID: <20180401162357.494c23a1@windsurf> (raw)
In-Reply-To: <20180331175420.19860-1-thomas.petazzoni@bootlin.com>
Hello,
On Sat, 31 Mar 2018 19:54:20 +0200, Thomas Petazzoni wrote:
> From: Waldemar Brodkorb <wbx@openadk.org>
>
> Since gcc 4.6, GCC deprecated -mfused-madd, -ffp-contract=off should
> be used for the Xburst workaround.
>
> Tested with the MIPS Sourcery 2011.03 toolchain (based on gcc 4.5),
> the toolchain wrapper uses -mno-fused-madd, as expected:
>
> $ BR2_DEBUG_WRAPPER=2 ./output/host/bin/mips-linux-gnu-gcc -o toto toto.c
> Toolchain wrapper executing:
> '/home/thomas/toolchains/mips-2011.03/bin/mips-linux-gnu-gcc'
> '--sysroot'
> '/home/thomas/projets/buildroot/output/host/mipsel-buildroot-linux-gnu/sysroot'
> '-mabi=32'
> '-msoft-float'
> '-mno-fused-madd'
> '-EL'
> '-march=mips32r2'
> '-o'
> 'toto'
> 'toto.c'
>
> And with the MIPS Sourcery 2012.09 toolchain (based on gcc 4.7), the
> toolchain wrapper uses -ffp-contract=off, as expected:
>
> $ BR2_DEBUG_WRAPPER=2 ./output/host/bin/mips-linux-gnu-gcc -o toto toto.c
> Toolchain wrapper executing:
> '/home/thomas/toolchains/mips-2012.09/bin/mips-linux-gnu-gcc'
> '--sysroot'
> '/home/thomas/projets/buildroot/output/host/mipsel-buildroot-linux-gnu/sysroot'
> '-mabi=32'
> '-msoft-float'
> '-ffp-contract=off'
> '-EL'
> '-march=mips32r2'
> '-o'
> 'toto'
> 'toto.c'
>
> Fixes the ci20_defconfig build:
>
> https://gitlab.com/buildroot.org/buildroot/-/jobs/60303132
>
> Signed-off-by: Waldemar Brodkorb <wbx@openadk.org>
> [Thomas: rework to continue supporting pre-gcc-4.6 toolchains, extend
> the commit log after doing more testing.]
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
> ---
> toolchain/toolchain-wrapper.c | 3 +++
> toolchain/toolchain-wrapper.mk | 6 ++++++
> 2 files changed, 9 insertions(+)
Applied to master, thanks.
Thomas
--
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
prev parent reply other threads:[~2018-04-01 14:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-31 17:54 [Buildroot] [PATCH] toolchain-wrapper: use -ffp-contract=off on MIPS Xburst for gcc >= 4.6 Thomas Petazzoni
2018-04-01 13:43 ` Ezequiel Garcia
2018-04-01 14:23 ` Thomas Petazzoni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180401162357.494c23a1@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox