Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] rust: make sure the cxx compiler is also set for the target
Date: Mon, 2 Apr 2018 00:57:38 +0200	[thread overview]
Message-ID: <20180402005738.1d603538@windsurf> (raw)
In-Reply-To: <F8479AD1-B731-4235-A6C6-A517165DD553@storagecraft.com>

Hello,

Thanks for the quick feedback!

On Sun, 1 Apr 2018 22:52:42 +0000, Charles Hardin wrote:
> We have a problem where we build on a HOST with x86_64 and RUST
> doesn?t realize the difference between the host tool chain and the buildroot
> toolchain.
> 
> In the old days - we had to patch rust to make a ?x86_64-buildroot-linux-gnu?
> target that would be recognized, but the latest patches removed that around
> rust 1.9 or so.
> 
> This was literally just looking at the logs and seeing the ?cc? was the buildroot
> cc and the the cxx was ?c++?, so it is just what we hacked together to get
> things to work.
> 
> But - definitely need to set ?cxx? in some appropriate fashion for rust to get
> compiled correctly.

Setting cxx looks definitely OK in your patch. It's the
RUSTC_HOST_NAME != RUSTC_TARGET_NAME that looks wrong.

Could you provide some specific examples (with defconfigs to reproduce)
for the two problems:

 - Lack of cxx variable

 - Case of RUSTC_HOST_NAME == RUSTC_TARGET_NAME

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com

  reply	other threads:[~2018-04-01 22:57 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-28 17:38 [Buildroot] [PATCH 1/1] rust: make sure the cxx compiler is also set for the target charles.hardin at storagecraft.com
2018-04-01 22:48 ` Thomas Petazzoni
2018-04-01 22:52   ` Charles Hardin
2018-04-01 22:57     ` Thomas Petazzoni [this message]
2018-04-01 23:00       ` Charles Hardin
2018-04-01 23:05         ` Charles Hardin
2018-04-02  6:38           ` Thomas Petazzoni
2018-04-02 19:54             ` Charles Hardin
2018-04-03 22:01               ` Eric Le Bihan
2018-04-03 22:11                 ` Charles Hardin
2018-12-16 13:41                 ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180402005738.1d603538@windsurf \
    --to=thomas.petazzoni@bootlin.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox