Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] Per-package download folders and Git caching
Date: Tue, 3 Apr 2018 22:48:20 +0200	[thread overview]
Message-ID: <20180403204820.GF2335@scaer> (raw)
In-Reply-To: <22d8a943-fdb2-f6ab-d81e-d9e0cc9b4df5@mind.be>

Arnout, All,

On 2018-04-03 22:44 +0200, Arnout Vandecappelle spake thusly:
> On 03-04-18 19:49, Yann E. MORIN wrote:
> > Peter, All,
> > 
> > On 2018-04-03 18:49 +0200, Peter Korsgaard spake thusly:
> >>>>>>> "Yann" == Yann E MORIN <yann.morin.1998@free.fr> writes:
> >>  > Should we do a cp if ln fails, then?
> >> That sounds like a sensible fallback, yes.
> > 
> > I was about to do so, but then we're back to a situation where we have
> > to guarantee the atomicity.
> > 
> > This is currently possible, because the dl-wrapper now runs under flock.
> > But we are going to optimise the locking with a more fine-grained
> > solution soonish.
> > 
> > To be noted: the current code is not atomic-safe either, because we do
> > have a TOCTTOU situation...
> > 
> > So, we'll have to again play tricks with atomicity...
> > 
> > We can't use flock again, because the destination directory is already
> > locked, and there is not destination file to lock to start with...
> > 
> > So, maybe the full solution will in fact to really implement the more
> > fine-grained solution... I'll see to it.
> 
>  Note that for the specific case I mentioned (hardlinks may not work over samba
> or VM shares), flock will fail as well...

Wait... So you're saying that we borked a working situation for a certain
class of users, now? Damn... :-/

And why would flock fail on those (curious)?

>  Maybe we should just wait until someone complains so they can test whatever
> solution we come up with.

In the end, yes, probably...

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

  reply	other threads:[~2018-04-03 20:48 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-03 12:17 [Buildroot] Per-package download folders and Git caching Thomas Petazzoni
2018-04-03 12:55 ` Arnout Vandecappelle
2018-04-03 13:17   ` Peter Korsgaard
2018-04-03 16:23     ` Yann E. MORIN
2018-04-03 16:49       ` Peter Korsgaard
2018-04-03 17:49         ` Yann E. MORIN
2018-04-03 18:10           ` Peter Korsgaard
2018-04-03 20:44           ` Arnout Vandecappelle
2018-04-03 20:48             ` Yann E. MORIN [this message]
2018-04-04 22:28               ` Arnout Vandecappelle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180403204820.GF2335@scaer \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox