From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2] autobuild-run: prepare_build(): ignore directories in dldir
Date: Wed, 4 Apr 2018 22:15:02 +0200 [thread overview]
Message-ID: <20180404221502.4ba6d628@windsurf> (raw)
In-Reply-To: <20180404164025.24814-1-peter@korsgaard.com>
Hello,
On Wed, 4 Apr 2018 18:40:25 +0200, Peter Korsgaard wrote:
> With the change to use subdirs in dldir, prepare_build may end up trying to
> remove a non-empty subdir, causing an exception:
>
> Process Process-1:
> Traceback (most recent call last):
> File "/usr/lib64/python2.7/multiprocessing/process.py", line 258, in _bootstrap
> self.run()
> File "/usr/lib64/python2.7/multiprocessing/process.py", line 114, in run
> self._target(*self._args, **self._kwargs)
> File "/home/peko/buildroot-test/scripts/autobuild-run", line 627, in run_instance
> ret = prepare_build(**kwargs)
> File "/home/peko/buildroot-test/scripts/autobuild-run", line 301, in prepare_build
> os.remove(os.path.join(dldir, f))
> OSError: [Errno 21] Is a directory: 'instance-0/dl/mtools'
>
> We only want to delete individual download files, so recursively search for
> files under dldir.
>
> With this change, flist contains the full path to the files, so also adjust
> the printing/removal logic.
>
> Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
> ---
> scripts/autobuild-run | 13 ++++++++++---
> 1 file changed, 10 insertions(+), 3 deletions(-)
Applied to buildroot-test repo. Thanks!
Thomas
--
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
prev parent reply other threads:[~2018-04-04 20:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-04 16:40 [Buildroot] [PATCH v2] autobuild-run: prepare_build(): ignore directories in dldir Peter Korsgaard
2018-04-04 20:15 ` Thomas Petazzoni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180404221502.4ba6d628@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox