From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] qt5base: remove use of QT5BASE_EXTRA_CFLAGS
Date: Thu, 5 Apr 2018 20:49:26 +0200 [thread overview]
Message-ID: <20180405184926.GA22364@scaer> (raw)
In-Reply-To: <1522881016-6423-1-git-send-email-joshua.henderson@microchip.com>
Joshua, All,
On 2018-04-04 15:30 -0700, Joshua Henderson spake thusly:
> This variable was added as part of an EGL i.MX6 workaround in commit
> (7e9f459adf), but appears to currently be abandonded and unused. Remove the use
> of the variable.
>
> Signed-off-by: Joshua Henderson <joshua.henderson@microchip.com>
Acked-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Regards,
Yann E. MORIN.
> ---
> package/qt5/qt5base/qt5base.mk | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/package/qt5/qt5base/qt5base.mk b/package/qt5/qt5base/qt5base.mk
> index a7eb0ec..750830a 100644
> --- a/package/qt5/qt5base/qt5base.mk
> +++ b/package/qt5/qt5base/qt5base.mk
> @@ -296,8 +296,8 @@ define QT5BASE_CONFIGURE_CMDS
> -nomake tests \
> -device buildroot \
> -device-option CROSS_COMPILE="$(TARGET_CROSS)" \
> - -device-option BR_COMPILER_CFLAGS="$(TARGET_CFLAGS) $(QT5BASE_EXTRA_CFLAGS)" \
> - -device-option BR_COMPILER_CXXFLAGS="$(TARGET_CXXFLAGS) $(QT5BASE_EXTRA_CFLAGS)" \
> + -device-option BR_COMPILER_CFLAGS="$(TARGET_CFLAGS)" \
> + -device-option BR_COMPILER_CXXFLAGS="$(TARGET_CXXFLAGS)" \
> $(QT5BASE_CONFIGURE_OPTS) \
> )
> endef
> --
> 2.7.4
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
next prev parent reply other threads:[~2018-04-05 18:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-04 22:30 [Buildroot] [PATCH] qt5base: remove use of QT5BASE_EXTRA_CFLAGS Joshua Henderson
2018-04-05 18:49 ` Yann E. MORIN [this message]
2018-04-09 9:26 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180405184926.GA22364@scaer \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox