From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/2] cramfs: change to new site location
Date: Fri, 6 Apr 2018 17:13:31 +0200 [thread overview]
Message-ID: <20180406171331.5b6891f9@windsurf> (raw)
In-Reply-To: <TY1PR01MB1562ADDDE3949C2BC35FC4408ABA0@TY1PR01MB1562.jpnprd01.prod.outlook.com>
Hello,
On Fri, 6 Apr 2018 15:02:55 +0000, Chris Brandt wrote:
> > It is missing the new case where the compressed block length is stored
> > as an u16 at the beginning of the block. That's pretty much the only use
> > of u16 in the code so easy to locate.
>
> So then in that case, you would need a bswap_32() and a bswap_16() macro.
>
> However...that code is currently inside a "} else if (0) {" block, so it
> looks like it will never get executed anyway.
I don't see where this else if (0) block is. Where do you see that ?
Matthew: the current patch in Buildroot also fixes cramfsck, but not
your contribution on the new version of the cramfs tools.
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2018-04-06 15:13 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-13 19:54 [Buildroot] [PATCH 0/2] cramfs: new maintainer, repo and XIP feature Chris Brandt
2018-02-13 19:54 ` [Buildroot] [PATCH 1/2] cramfs: change to new site location Chris Brandt
2018-02-13 20:14 ` Thomas Petazzoni
2018-02-13 20:24 ` Chris Brandt
2018-02-13 20:26 ` Thomas Petazzoni
2018-02-13 21:08 ` Chris Brandt
2018-02-14 17:37 ` Chris Brandt
2018-04-05 19:07 ` Matthew Weber
2018-04-06 15:02 ` Chris Brandt
2018-04-06 15:13 ` Thomas Petazzoni [this message]
2018-04-06 15:19 ` Chris Brandt
2018-04-06 15:29 ` Thomas Petazzoni
2018-04-06 15:41 ` Matthew Weber
2018-04-06 15:38 ` Matthew Weber
2018-04-06 15:36 ` Matthew Weber
[not found] ` <nycvar.YSQ.7.76.1804061138320.28462@knanqh.ubzr>
2018-04-06 15:43 ` Matthew Weber
[not found] ` <nycvar.YSQ.7.76.1804061305080.28462@knanqh.ubzr>
2018-04-06 18:29 ` Matthew Weber
[not found] ` <nycvar.YSQ.7.76.1804061446470.28462@knanqh.ubzr>
2018-04-06 19:07 ` Chris Brandt
2018-02-13 19:54 ` [Buildroot] [PATCH 2/2] cramfs: add xip option Chris Brandt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180406171331.5b6891f9@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox