From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] download/git: fix trasnform-name
Date: Sun, 8 Apr 2018 10:24:51 +0200 [thread overview]
Message-ID: <20180408082451.GA2327@scaer> (raw)
In-Reply-To: <5ac9c6165105e_7b0e2af9278483201172d@ultri4.mail>
Ricardo, All,
On 2018-04-08 04:34 -0300, Ricardo Martincoski spake thusly:
> > download/git: fix trasnform-name
> trasnform -> transform
Meh, that is my signature. A mail from me with no typo is not from me...
;-)
> On Sat, Apr 07, 2018 at 06:26 PM, Yann E. MORIN wrote:
> > When a package contains a relative symlink which first component is '..'
> > (thus pointing one directory higher), for example package 'meh' contains
> > this symlink:
> >
> > foo/bar -> ../buz
> >
> > then it would be stored as 'meh-version./buz' because of the
> > transform-name pattern replacement.
> >
> > Fix it to only match the leading './'.
> >
> > Reported-by: Ricardo Martincoski <ricardo.martincoski@gmail.com>
> > Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> > Cc: Ricardo Martincoski <ricardo.martincoski@gmail.com>
> > Cc: Peter Korsgaard <peter@korsgaard.com>
> > Cc: Maxime Hadjinlian <maxime.hadjinlian@gmail.com>
>
> With the typo in the subject fixed:
> Reviewed-by: Ricardo Martincoski <ricardo.martincoski@gmail.com>
> [tarball generation fixed for 18xx-ti-utils and linux-firmware, see the test
> script at http://patchwork.ozlabs.org/patch/896012/ ]
> Tested-by: Ricardo Martincoski <ricardo.martincoski@gmail.com>
>
> 2 packages are fixed by this patch:
> 18xx-ti-utils
> before: https://gitlab.com/RicardoMartincoski/buildroot/-/jobs/61769469
> after: https://gitlab.com/RicardoMartincoski/buildroot/-/jobs/61769909
> linux-firmware
> before: https://gitlab.com/RicardoMartincoski/buildroot/-/jobs/61769511
> after: https://gitlab.com/RicardoMartincoski/buildroot/-/jobs/61769952
>
> All failures with this patch:
> https://gitlab.com/RicardoMartincoski/buildroot/pipelines/20146714/failures
> at91bootstrap3 v3.8.6, gummiboot, kvm-unit-tests, kvmtool, mcelog, trace-cmd,
> uemacs, xloader
> also occured for 2018.02:
> https://gitlab.com/RicardoMartincoski/buildroot/pipelines/20146633/failures
Sorry, but I'm not following. You mean that 18xx-ti-utils and
linux-firmware are already broken on 2018.02? That is strange, because
we haven't backported those git download changes in the LTS branch...
And indeed, I can't reproduce the issue locally, using tar-1.29. What
version of tar are you using? We've recently black-listed 1.26 and
below, and now require 1.27 <= tar <= 1.29
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
next prev parent reply other threads:[~2018-04-08 8:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-07 21:26 [Buildroot] [PATCH] download/git: fix trasnform-name Yann E. MORIN
2018-04-08 7:34 ` Ricardo Martincoski
2018-04-08 8:24 ` Yann E. MORIN [this message]
2018-04-08 13:37 ` Ricardo Martincoski
2018-04-08 15:41 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180408082451.GA2327@scaer \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox