Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 2/2] package/flare-game: new package
Date: Mon, 9 Apr 2018 21:58:29 +0200	[thread overview]
Message-ID: <20180409215829.732e1b3b@windsurf> (raw)
In-Reply-To: <20180319211903.11539-2-romain.naour@gmail.com>

Hello,

On Mon, 19 Mar 2018 22:19:03 +0100, Romain Naour wrote:

> +	  flare-game is a package that requires flare-engine that only
> +	  contains this game data.

The double "that" here wasn't very clear, so I've reworded this to:

+         This package, flare-game, only contains the game data. The
+         game engine itself is part of a separate package,
+         flame-engine.

> +FLARE_GAME_DEPENDENCIES += flare-engine

Dropped the += to be just = here.

> +# Don't use /usr/share/games
> +FLARE_GAME_CONF_OPTS += -DDATADIR=share/flare

I should have done the same here, but I haven't. Not a big deal.

Applied to master with those changes. Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com

  reply	other threads:[~2018-04-09 19:58 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-19 21:19 [Buildroot] [PATCH 1/2] package/flare-engine: new package Romain Naour
2018-03-19 21:19 ` [Buildroot] [PATCH 2/2] package/flare-game: " Romain Naour
2018-04-09 19:58   ` Thomas Petazzoni [this message]
2018-04-09 19:42 ` [Buildroot] [PATCH 1/2] package/flare-engine: " Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180409215829.732e1b3b@windsurf \
    --to=thomas.petazzoni@bootlin.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox