From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v6 1/4] imx-mkimage: new package
Date: Tue, 10 Apr 2018 08:56:45 +0200 [thread overview]
Message-ID: <20180410085645.7a74d6b6@windsurf> (raw)
In-Reply-To: <CAPP7BN1C+Z-i5Vvv60TwycBL7cn6GMwdR+=vdPY-w6ZevsBpsg@mail.gmail.com>
Hello,
On Tue, 10 Apr 2018 07:27:22 +0200, Erik Larsson wrote:
> > This commit log really needs to be extended. What was the need to add
> > LDFLAGS ? It seems like a very simple program, which could be built
> > without special LDFLAGS. What was the issue that lead you to add this
> > patch ?
>
> If LDFLAGS is not added it will use the host machine libz, and fail if
> not available, but by adding LDFLAGS it will build using Buildroot
> compiled libz.
Hum, indeed, we're building a host package here, so we need to
explicitly pass -L$(HOST_DIR)/lib, otherwise we link against the
system-provided libraries.
> Do you want me to update the patch information in a new patch?
Yes, that would be nice. Thanks!
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2018-04-10 6:56 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-10 11:51 [Buildroot] [PATCH v6 0/4] Initial support for NXP iMX8 (imx8mq-evk) Erik Larsson
2018-03-10 11:51 ` [Buildroot] [PATCH v6 1/4] imx-mkimage: new package Erik Larsson
2018-04-09 20:07 ` Thomas Petazzoni
2018-04-10 5:27 ` Erik Larsson
2018-04-10 6:56 ` Thomas Petazzoni [this message]
2018-03-10 11:51 ` [Buildroot] [PATCH v6 2/4] freescale-imx: add config option for i.MX8M Erik Larsson
2018-04-09 20:08 ` Thomas Petazzoni
2018-03-10 11:51 ` [Buildroot] [PATCH v6 3/4] firmware-imx: add support for iMX8M firmware Erik Larsson
2018-04-09 20:38 ` Thomas Petazzoni
2018-03-10 11:51 ` [Buildroot] [PATCH v6 4/4] configs/freescale_imx8mqevk: new defconfig Erik Larsson
2018-04-09 20:42 ` Thomas Petazzoni
2018-04-09 20:46 ` Fabio Estevam
2018-04-10 5:37 ` Erik Larsson
2018-04-10 17:31 ` Erik Larsson
2018-04-10 21:26 ` Thomas Petazzoni
2018-04-11 5:23 ` Erik Larsson
2018-03-28 9:23 ` [Buildroot] [PATCH v6 0/4] Initial support for NXP iMX8 (imx8mq-evk) Erik Larsson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180410085645.7a74d6b6@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox