Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] package/linux-firmware: Add Qualcomm video firmware option
Date: Wed, 11 Apr 2018 09:03:59 +0200	[thread overview]
Message-ID: <20180411090359.7a25742c@windsurf> (raw)
In-Reply-To: <CAEj2-1MXk1LHVQbJ8+68rncDMEYf6GpjC5daO5GrRA9Wyf-FXw@mail.gmail.com>

Hello Andre,

On Wed, 11 Apr 2018 02:09:46 +0000, Andre Renaud wrote:
> Added Qualcomm video accelerator and GPU firmware option.
> 
> Signed-off-by: Andre Renaud <andre@ignavus.net>
> ---
>  package/linux-firmware/Config.in         | 10 ++++++++++
>  package/linux-firmware/linux-firmware.mk | 10 ++++++++++
>  2 files changed, 20 insertions(+)

Thanks for this new version! Could you please sent this as a proper new
patch with git send-email, and not pasted above the previous patch?
Also, see beloiw.

> diff --git a/package/linux-firmware/Config.in
> b/package/linux-firmware/Config.in
> index 4e77a3f9a3..9d8d8b340b 100644
> --- a/package/linux-firmware/Config.in
> +++ b/package/linux-firmware/Config.in
> @@ -29,6 +29,16 @@ config BR2_PACKAGE_LINUX_FIRMWARE_RADEON
>   help
>     Firmware files for AMD Radeon video cards.
> 
> +config BR2_PACKAGE_LINUX_FIRMWARE_QCOM_VENUS
> +       bool "Qualcomm Venus video codec accelerator"
> +       help

Indentation should be done with tabs

> +         Firmware files for Qualcomm Venus video codec accelerator

And here one tab + 2 spaces.

You can run ./utils/check-package package/linux-firmware/Config.in,
which well validate this kind of trivial coding style issues.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com

      parent reply	other threads:[~2018-04-11  7:03 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-11 21:57 [Buildroot] [PATCH] package/linux-firmware: Add Qualcomm video firmware option Andre Renaud
2018-03-26 21:32 ` Thomas Petazzoni
2018-04-11  2:09   ` Andre Renaud
2018-04-11  5:09     ` Baruch Siach
2018-04-11  7:03     ` Thomas Petazzoni [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180411090359.7a25742c@windsurf \
    --to=thomas.petazzoni@bootlin.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox