From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Petazzoni Date: Wed, 11 Apr 2018 11:35:56 +0200 Subject: [Buildroot] [PATCH v4 2/8] gst-plugins-${base, good, bad, ugly}: bump to 1.14.0 In-Reply-To: References: <20180322173220.31791-1-aduskett@gmail.com> <20180322173220.31791-2-aduskett@gmail.com> <20180322235537.261ea603@gmx.net> <20180410100736.2e6f8f7b@windsurf> <20180410182813.691be3ff@gmx.net> <20180410234019.2fc5516d@windsurf> Message-ID: <20180411113556.79d7aa32@windsurf> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: buildroot@busybox.net Hello, On Wed, 11 Apr 2018 08:56:56 +0200, Peter Seiderer wrote: > > Not sure to understand what you say here. Do you say: "This option > > already exists in the current version of GStreamer packaged by > > Buildroot, and continues to exist in 1.14.0 and therefore should be > > kept in Buildroot, i.e BR2_PACKAGE_GST1_PLUGINS_BAD_LIB_OPENGL_WAYLAND > > should stay. > > I think the BR2_PACKAGE_GST1_PLUGINS_BAD_LIB_OPENGL_WAYLAND could/should > move to base, but the waylandsink enabling BR2_PACKAGE_GST1_PLUGINS_BAD_PLUGIN_WAYLAND > should stay in bad....(maybe the confusion comes from the double use of > --enable-wayland option in gst1-plugins-bad enabling wayland support in > libGstGl and/or enabling the waylandsink element)... > > From package/gstreamer1/gst1-plugins-bad/gst1-plugins-bad.mk: > > ifneq ($(BR2_PACKAGE_GST1_PLUGINS_BAD_LIB_OPENGL_WAYLAND)$(BR2_PACKAGE_GST1_PLUGINS_BAD_PLUGIN_WAYLAND),) > GST1_PLUGINS_BAD_CONF_OPTS += --enable-wayland > GST1_PLUGINS_BAD_DEPENDENCIES += wayland wayland-protocols > else > GST1_PLUGINS_BAD_CONF_OPTS += --disable-wayland > endif > > > From package/gstreamer1/gst1-plugins-bad/Config.in: > > config BR2_PACKAGE_GST1_PLUGINS_BAD_LIB_OPENGL_WAYLAND > bool "wayland" > default y > depends on BR2_PACKAGE_GST1_PLUGINS_BAD_LIB_OPENGL_EGL > depends on BR2_PACKAGE_WAYLAND > select BR2_PACKAGE_WAYLAND_PROTOCOLS > select BR2_PACKAGE_GST1_PLUGINS_BAD_LIB_OPENGL_HAS_WINDOW > [...] > config BR2_PACKAGE_GST1_PLUGINS_BAD_PLUGIN_WAYLAND > bool "wayland" > default y > depends on BR2_PACKAGE_WAYLAND > select BR2_PACKAGE_WAYLAND_PROTOCOLS > help > Wayland Video Sink > > I get a running waylandsink with: > > # BR2_PACKAGE_GST1_PLUGINS_BASE_LIB_OPENGL_WAYLAND is not set > BR2_PACKAGE_GST1_PLUGINS_BAD_PLUGIN_WAYLAND=y Still not sure to fully understand what you're proposing. Do you think you could take over this series, make the changes that you think are necessary and resubmit ? This would be useful to help the discussion move forward. Thanks! Thomas -- Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons) Embedded Linux and Kernel engineering https://bootlin.com