From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2 2/6] zstd: add host libzstd support
Date: Wed, 11 Apr 2018 23:19:07 +0200 [thread overview]
Message-ID: <20180411211907.GE2328@scaer> (raw)
In-Reply-To: <20180409200429.22650-2-ps.report@gmx.net>
Peter, All,
On 2018-04-09 22:04 +0200, Peter Seiderer spake thusly:
> Signed-off-by: Peter Seiderer <ps.report@gmx.net>
> ---
> Changes v1 -> v2:
> - split off host libzstd support (suggested by Yann E. MORIN)
> - no ZSTD_OPTS for host libarary build
> ---
> package/zstd/zstd.mk | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
>
> diff --git a/package/zstd/zstd.mk b/package/zstd/zstd.mk
> index c0fa88026c..1b76b0164c 100644
> --- a/package/zstd/zstd.mk
> +++ b/package/zstd/zstd.mk
> @@ -46,4 +46,16 @@ define ZSTD_INSTALL_TARGET_CMDS
> DESTDIR=$(TARGET_DIR) PREFIX=/usr -C $(@D)/programs install
> endef
>
> +# note: no 'HAVE_...' options for host library build only
> +define HOST_ZSTD_BUILD_CMDS
> + $(HOST_MAKE_ENV) $(HOST_CONFIGURE_OPTS) $(MAKE) \
> + -C $(@D) lib
> +endef
> +
> +define HOST_ZSTD_INSTALL_CMDS
> + $(HOST_MAKE_ENV) $(HOST_CONFIGURE_OPTS) $(MAKE) \
> + DESTDIR=$(HOST_DIR) PREFIX=/usr -C $(@D)/lib install
> +endef
> +
> $(eval $(generic-package))
> +$(eval $(host-generic-package))
The target variant has optional dependencies on zlib, xz, and lz4, which
all have host variants.
So, if you don;t specify the dependency in the host-zstd, you get a
host-zstd that may or may not have support for zlib, xz, or lz4,
depending on hether another package a dependency on them.
We don't have spport for optional host dependencies (because there are
not config options for those host packages), so I don't see a solution
but to always depend on all three. So:
HOST_ZSTD_DEPENDENCIES = host-lz4 host-xz host-zlib
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
next prev parent reply other threads:[~2018-04-11 21:19 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-09 20:04 [Buildroot] [PATCH v2 1/6] squashfs: bump version to e38956b92f738518c29734399629e7cdb33072d3 Peter Seiderer
2018-04-09 20:04 ` [Buildroot] [PATCH v2 2/6] zstd: add host libzstd support Peter Seiderer
2018-04-11 21:19 ` Yann E. MORIN [this message]
2018-04-12 3:33 ` Baruch Siach
2018-04-12 18:30 ` Peter Seiderer
2018-04-12 18:47 ` Yann E. MORIN
2018-04-09 20:04 ` [Buildroot] [PATCH v2 3/6] squashfs: add host zstd support Peter Seiderer
2018-04-11 21:20 ` Yann E. MORIN
2018-04-09 20:04 ` [Buildroot] [PATCH v2 4/6] fs/squashfs: add " Peter Seiderer
2018-04-09 20:04 ` [Buildroot] [PATCH v2 5/6] zstd: add libzstd support Peter Seiderer
2018-04-11 21:24 ` Yann E. MORIN
2018-04-12 18:45 ` Peter Seiderer
2018-04-09 20:04 ` [Buildroot] [PATCH v2 6/6] squashfs: add zstd support Peter Seiderer
2018-04-11 21:27 ` Yann E. MORIN
2018-04-12 18:31 ` Peter Seiderer
2018-04-11 21:12 ` [Buildroot] [PATCH v2 1/6] squashfs: bump version to e38956b92f738518c29734399629e7cdb33072d3 Yann E. MORIN
2018-04-12 18:51 ` Peter Seiderer
2018-04-12 19:01 ` Thomas Petazzoni
2018-04-12 21:43 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180411211907.GE2328@scaer \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox