From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] pixiewps: new package
Date: Thu, 12 Apr 2018 13:30:06 +0200 [thread overview]
Message-ID: <20180412133006.2af0467b@windsurf> (raw)
In-Reply-To: <1523526148-9678-1-git-send-email-guillaume.bressaix@gmail.com>
Hello,
Thanks for this new version. However, you forgot to take into account
some comments from the previous version, including a major one.
On Thu, 12 Apr 2018 11:42:28 +0200, Guillaume W. Bres wrote:
> diff --git a/package/pixiewps/Config.in b/package/pixiewps/Config.in
> new file mode 100644
> index 0000000..013e7f6
> --- /dev/null
> +++ b/package/pixiewps/Config.in
> @@ -0,0 +1,8 @@
> +config BR2_PACKAGE_PIXIEWPS
> + bool "pixiewps"
> +
Unneeded empty line.
> +PIXIEWPS_VERSION = 9e5bdc6c86c8487b2a6107d5ab3559ed5c738c59
> +PIXIEWPS_SITE = $(call github,wiire-a,pixiewps,$(PIXIEWPS_VERSION))
> +PIXIEWPS_LICENSE = GPL-2.0+
> +PIXIEWPS_LICENSE_FILES = LICENSE.md
> +
> +PIXIEWPS_SUBDIR = src
> +
> +$(eval $(generic-package))
The most important comment: this package doesn't do anything. A
generic-package without any BUILD_CMDS and INSTALL_TARGET_CMDS will not
do anything besides downloading the source code and extracting it.
How did you test this ? I don't see how it can produce anything useful.
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2018-04-12 11:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-12 9:42 [Buildroot] [PATCH 1/1] pixiewps: new package Guillaume W. Bres
2018-04-12 11:30 ` Thomas Petazzoni [this message]
-- strict thread matches above, loose matches on Subject: below --
2018-04-12 13:18 Guillaume W. Bres
2018-04-12 14:42 ` Baruch Siach
2018-04-12 21:42 ` Thomas Petazzoni
2018-04-13 8:00 ` Guillaume W. Bres
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180412133006.2af0467b@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox