Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] Added Qualcomm video accelerator and GPU firmware option.
Date: Thu, 12 Apr 2018 13:54:28 +0200	[thread overview]
Message-ID: <20180412135428.6c4cdf50@windsurf> (raw)
In-Reply-To: <20180411213938.5888-1-andre@ignavus.net>

Hello Andre,

On Thu, 12 Apr 2018 09:39:38 +1200, Andre Renaud wrote:
> From: Andre Renaud <arenaud@designa-electronics.com>
> 
> Signed-off-by: Andre Renaud <andre@ignavus.net>

I fixed up the title to be:

	linux-firmware: add Qualcomm video accelerator and GPU firmware options

but then I tested it, and your patch triggers an issue in our fix-rpath
script: the patchelf program doesn't like the ELF files that act as
firmware files for the Qualcomm VPU:

/home/thomas/projets/buildroot/support/scripts/fix-rpath target
/home/thomas/projets/buildroot/support/scripts/fix-rpath: line 60:  5156 Aborted                 (core dumped) ${PATCHELF} --print-rpath "${file}" > /dev/null 2>&1
/home/thomas/projets/buildroot/support/scripts/fix-rpath: line 60:  5163 Aborted                 (core dumped) ${PATCHELF} --print-rpath "${file}" > /dev/null 2>&1
/home/thomas/projets/buildroot/support/scripts/fix-rpath: line 60:  5174 Aborted                 (core dumped) ${PATCHELF} --print-rpath "${file}" > /dev/null 2>&1
/home/thomas/projets/buildroot/support/scripts/fix-rpath: line 60:  5209 Aborted                 (core dumped) ${PATCHELF} --print-rpath "${file}" > /dev/null 2>&1
/home/thomas/projets/buildroot/support/scripts/fix-rpath: line 60:  5229 Aborted                 (core dumped) ${PATCHELF} --print-rpath "${file}" > /dev/null 2>&1
/home/thomas/projets/buildroot/support/scripts/fix-rpath: line 60:  5258 Aborted                 (core dumped) ${PATCHELF} --print-rpath "${file}" > /dev/null 2>&1

So, I've submitted a patch that adjusts our fix-rpath script to
ignore /lib/firmware: http://patchwork.ozlabs.org/patch/897624/

I'll wait a bit to see if anyone has some comments about this patch
(and potentially give some Acked-by), as I need to apply such a fix
before applying your patch.

I'm surprised that you haven't see the issue, though.

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com

  reply	other threads:[~2018-04-12 11:54 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-11 21:39 [Buildroot] [PATCH] Added Qualcomm video accelerator and GPU firmware option Andre Renaud
2018-04-12 11:54 ` Thomas Petazzoni [this message]
2018-04-12 19:26 ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180412135428.6c4cdf50@windsurf \
    --to=thomas.petazzoni@bootlin.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox