From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/4] firmware-imx: add support for iMX8M firmware
Date: Thu, 12 Apr 2018 22:18:11 +0200 [thread overview]
Message-ID: <20180412221811.21ec0b45@windsurf> (raw)
In-Reply-To: <1523536525-10280-1-git-send-email-karl.erik.larsson@gmail.com>
Hello,
On Thu, 12 Apr 2018 14:35:22 +0200, Erik Larsson wrote:
> +ifeq ($(BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX8M),y)
> +FIRMWARE_IMX_INSTALL_IMAGES = YES
> +define FIRMWARE_IMX_PREPARE_LPDDR4_FW
> + (cd $(@D)/firmware/ddr/synopsys/ && \
> + $(TARGET_OBJCOPY) -I binary -O binary --pad-to 0x8000 --gap-fill=0x0 \
> + lpddr4_pmu_train_$(1)_imem.bin \
> + lpddr4_pmu_train_$(1)_imem_pad.bin && \
> + $(TARGET_OBJCOPY) -I binary -O binary --pad-to 0x4000 --gap-fill=0x0 \
> + lpddr4_pmu_train_$(1)_dmem.bin \
> + lpddr4_pmu_train_$(1)_dmem_pad.bin && \
> + cat lpddr4_pmu_train_$(1)_imem_pad.bin lpddr4_pmu_train_$(1)_dmem_pad.bin > \
> + lpddr4_pmu_train_$(1)_fw.bin \
> + )
It was still a bit annoying that we had to have all those commands
inside a single command, so I've instead introduced a
FIRMWARE_IMX_DDRFW_DIR variable, set to $(@D)/firmware/ddr/synopsys/
and used that everywhere. To me it makes the whole thing more readable.
Applied to master with this change.
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
prev parent reply other threads:[~2018-04-12 20:18 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-12 12:35 [Buildroot] [PATCH 1/4] firmware-imx: add support for iMX8M firmware Erik Larsson
2018-04-12 12:35 ` [Buildroot] [PATCH 2/4] imx: make post-image.sh arm64 compatible Erik Larsson
2018-04-12 20:35 ` Thomas Petazzoni
2018-04-12 12:35 ` [Buildroot] [PATCH 3/4] imx: add imx8 boot preparation script Erik Larsson
2018-04-12 20:50 ` Thomas Petazzoni
2018-04-12 12:35 ` [Buildroot] [PATCH 4/4] configs/freescale_imx8mqevk: new defconfig Erik Larsson
2018-04-12 20:50 ` Thomas Petazzoni
2018-04-12 20:18 ` Thomas Petazzoni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180412221811.21ec0b45@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox