Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] support/download/dl-wrapper: pass the correct -N option
Date: Thu, 12 Apr 2018 22:54:33 +0200	[thread overview]
Message-ID: <20180412225433.0b69c821@windsurf> (raw)
In-Reply-To: <20180411081024.15097-1-thomas.petazzoni@bootlin.com>

Hello,

On Wed, 11 Apr 2018 10:10:24 +0200, Thomas Petazzoni wrote:
> ${raw_name} is never defined in dl-wrapper, and therefore the value
> passed to the -N option is always empty. This causes a problem for the
> 'cvs' backend, which uses the value of this option as the CVS module
> to be downloaded.
> 
> If the name of the CVS module is omitted, all the CVS modules from
> that CVS repository are downloaded, which creates a tarball with a lot
> more contents, and the actual useful contents in a sub-directory,
> obviously breaking patches that should be applied, and the entire
> build process that follows.
> 
> Fixes:
> 
>   http://autobuild.buildroot.net/results/fcee0e3d7eeeb373313b1794092c729b1b052348/
> 
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
> ---
>  support/download/dl-wrapper | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Applied to master, thanks.

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com

      parent reply	other threads:[~2018-04-12 20:54 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-11  8:10 [Buildroot] [PATCH] support/download/dl-wrapper: pass the correct -N option Thomas Petazzoni
2018-04-11 17:39 ` Yann E. MORIN
2018-04-12 20:54 ` Thomas Petazzoni [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180412225433.0b69c821@windsurf \
    --to=thomas.petazzoni@bootlin.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox