From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Petazzoni Date: Thu, 12 Apr 2018 23:32:55 +0200 Subject: [Buildroot] [PATCH 1/1] Makefile: Take default SOURCE_DATE_EPOCH from repo containing Makefile In-Reply-To: <1523356092-16037-1-git-send-email-james.byrne@origamienergy.com> References: <1523356092-16037-1-git-send-email-james.byrne@origamienergy.com> Message-ID: <20180412233255.0c853211@windsurf> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: buildroot@busybox.net Hello, On Tue, 10 Apr 2018 11:28:12 +0100, James Byrne wrote: > For reproducible builds, SOURCE_DATE_EPOCH will be set to the git commit > date if it is not defined in the environment, but this was done by > explicitly using $(TOPDIR)/.git as the git repository, which would not > give the expected result if Buildroot had been put into a subdirectory > of another repository. > > This commit removes that restriction, meaning that the default date will > now be the date of the git commit that contains Makefile, regardless of > what level above Makefile the repository is at. This works because the > current directory when the 'git log' command is executed will always be > the directory containing Makefile (it must be, since TOPDIR is set from > CURDIR). > > In general this should be a sensible default, and in cases where a > different date is required SOURCE_DATE_EPOCH can be defined in the > environment before invoking make. > > Signed-off-by: James Byrne > --- > Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Applied to master, thanks. Thomas -- Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons) Embedded Linux and Kernel engineering https://bootlin.com