Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] tcf-agent: bump to version 1.7.0
Date: Fri, 13 Apr 2018 13:18:52 +0200	[thread overview]
Message-ID: <20180413131852.6df79113@windsurf> (raw)
In-Reply-To: <CADYdroNbVjuEk-4e_=WDs30v6sm9ZTvOb2_DtJdA9XLKQXZRBQ@mail.gmail.com>

Hello,

On Fri, 13 Apr 2018 11:32:52 +0200, Norbert Lange wrote:

> There aren't any features of CMake used,
> not for detecting libraries, not for detecting headers, not for getting flags,
> all of this is missing compared to the Makefile. All that's there is a
> subset of the fixed flags + logic from other buildsystems.
> If that's an improvement for you, then there's not much left to discuss.
> 
> Proper CMake support would need all that (at which point it is surely
> better than make),
> and I expect you will get alot of warnings now in builds, since some
> feature detection macros are missing.

I build tcf-agent 1.7.0, using the patch provided by Eugene, and it
built without warnings.

> I wont add proper CMake support myself (as I first considered it), as
> I would have to dissect the information form other build-systems,
> and keep it current every new version.

Maybe we should just ask Eugene was is the official and
upstream-supported build system for tcf-agent. Using CMake instead of
hand-written Makefiles definitely makes a lot of sense. It does work
today, and if there are some issues with it, they can be fixed.

Look at your patch that was fixing the static linking issue with
OpenSSL. CMake has built-in support for detecting libraries using
pkg-config, automatically solving such static linking issues.

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com

  reply	other threads:[~2018-04-13 11:18 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-12 15:13 [Buildroot] [PATCH 1/1] tcf-agent: bump to version 1.7.0 Eugene Tarassov
2018-04-12 21:49 ` Thomas Petazzoni
2018-04-13  1:50   ` Evgueni Tarassov
2018-04-13  7:50     ` Norbert Lange
2018-04-13  7:53       ` Norbert Lange
2018-04-13  7:53       ` Thomas Petazzoni
2018-04-13  8:13 ` Thomas Petazzoni
2018-04-13  9:32   ` Norbert Lange
2018-04-13 11:18     ` Thomas Petazzoni [this message]
2018-04-13 11:33       ` Norbert Lange

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180413131852.6df79113@windsurf \
    --to=thomas.petazzoni@bootlin.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox