From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Petazzoni Date: Sun, 15 Apr 2018 21:37:40 +0200 Subject: [Buildroot] [PATCH 1/2] alsa-lib: bump to version 1.1.6 In-Reply-To: <20180413072825.14512-1-joerg.krause@embedded.rocks> References: <20180413072825.14512-1-joerg.krause@embedded.rocks> Message-ID: <20180415213740.1afeebf2@windsurf.numericable.fr> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: buildroot@busybox.net Hello, On Fri, 13 Apr 2018 09:28:24 +0200, J?rg Krause wrote: > Regenerate patches using git as patch 0002 didn't applied and the others were > fuzzy. > > Signed-off-by: J?rg Krause I've applied, but I had to fix a few things in the patches. See below. > diff --git a/package/alsa-lib/0001-no-mmu.patch b/package/alsa-lib/0001-no-mmu.patch > index 2ae0f67158..0114e29d64 100644 > --- a/package/alsa-lib/0001-no-mmu.patch > +++ b/package/alsa-lib/0001-no-mmu.patch > @@ -1,14 +1,27 @@ > +From fac9e178f0d221c33efa579f54f6456156570088 Mon Sep 17 00:00:00 2001 > +From: =?UTF-8?q?J=C3=B6rg=20Krause?= First, it's better to keep the original authorship. I.e me for patch 0001, Sonic Zhang for patch 0002, and Thomas DS for patch 0003. You can do this by using --author="..." > +Date: Fri, 13 Apr 2018 09:02:37 +0200 > +Subject: [PATCH 1/3] no mmu I guess you've chosen those titles so that the name of the patch file generated by git format-patch remains the same. But I don't think that's really a requirement (that it stays the same) and a better commit title is more important I believe. Therefore, I've changed the title to "Don't use fork(= on noMMU platforms", which was already in the commit log. Also, you should use "git format-patch -N" when generating patch series that go in packages, to avoid the 1/3, 2/3 and 3/3 numbering. BTW, what about trying to submit those patches upstream ? Anyway, as said above, I've applied to master after adjusting the patches. Thanks! Thomas -- Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons) Embedded Linux and Kernel engineering https://bootlin.com