From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] linux-firmware: support paths with subdirs in LINUX_FIRMWARE_DIRS
Date: Mon, 16 Apr 2018 10:34:19 +0200 [thread overview]
Message-ID: <20180416083419.GA2394@scaer> (raw)
In-Reply-To: <20180415202245.8720-1-thomas.petazzoni@bootlin.com>
Thomas, All,
On 2018-04-15 22:22 +0200, Thomas Petazzoni spake thusly:
> Following commit cdb7876f63a253254b86637aaac8b255a426b60a
> ("linux-firmware: add Qualcomm video accelerator and GPU firmware
> options"), LINUX_FIRMWARE_DIRS can now contain entries with subdirs,
> such as "qcom/venus-1.8". Such entries are currently not supported by
> the logic in LINUX_FIRMWARE_INSTALL_DIRS.
>
> Indeed the current logic consists in:
>
> - Removing the destination directory
> - Copying to the destination directory
>
> Unfortunately, the last step fails if a component of the path leading
> to the destination directory does not exist. To overcome this, we
> simply add the appropriate mkdir before the copy.
>
> Fixes:
>
> http://autobuild.buildroot.net/results/54cbca90742faf486e59d95b95a0b0494e47b385/
>
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Regards,
Yann E. MORIN.
> ---
> package/linux-firmware/linux-firmware.mk | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/package/linux-firmware/linux-firmware.mk b/package/linux-firmware/linux-firmware.mk
> index efe5cdd7dd..11231613e9 100644
> --- a/package/linux-firmware/linux-firmware.mk
> +++ b/package/linux-firmware/linux-firmware.mk
> @@ -499,6 +499,7 @@ ifneq ($(LINUX_FIRMWARE_DIRS),)
> define LINUX_FIRMWARE_INSTALL_DIRS
> $(foreach d,$(LINUX_FIRMWARE_DIRS), \
> rm -rf $(TARGET_DIR)/lib/firmware/$(d); \
> + mkdir -p $(dir $(TARGET_DIR)/lib/firmware/$(d)); \
> cp -a $(@D)/$(d) $(TARGET_DIR)/lib/firmware/$(d)$(sep))
> endef
> endif
> --
> 2.14.3
>
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
next prev parent reply other threads:[~2018-04-16 8:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-15 20:22 [Buildroot] [PATCH] linux-firmware: support paths with subdirs in LINUX_FIRMWARE_DIRS Thomas Petazzoni
2018-04-16 8:34 ` Yann E. MORIN [this message]
2018-04-16 12:52 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180416083419.GA2394@scaer \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox