From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Petazzoni Date: Thu, 19 Apr 2018 22:50:17 +0200 Subject: [Buildroot] [PATCH 2/2] lz4: improve static only build support In-Reply-To: <0d4f47355e8ecd124338524f94947fd7cd3e3cb0.1524131196.git.baruch@tkos.co.il> References: <0d4f47355e8ecd124338524f94947fd7cd3e3cb0.1524131196.git.baruch@tkos.co.il> Message-ID: <20180419225017.308d2d1e@windsurf.numericable.fr> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: buildroot@busybox.net Hello Baruch, On Thu, 19 Apr 2018 12:46:36 +0300, Baruch Siach wrote: > The current method of supporting static only build, removal of all lines > that match the SHARED regex from lib/Makefile, is crude and fragile. > Instead, patch lib/Makefile to allow disable of shared libraries. > > Signed-off-by: Baruch Siach Thanks for cleaning this up, looks like a good idea. However... > +LZ4_MAKE_OPTS = DESTDIR=$(STAGING_DIR) PREFIX=/usr This looks weird. Why is DESTDIR needed at build time ? And how a DESTDIR=$(STAGING_DIR) in the INSTALL_TARGET_CMDS be the correct thing ? Best regards, Thomas -- Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons) Embedded Linux and Kernel engineering https://bootlin.com