From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [git commit] usb_modeswitch: set CXX to false when C++ is missing
Date: Fri, 20 Apr 2018 15:59:57 +0200 [thread overview]
Message-ID: <20180420155957.58f2bc90@windsurf.numericable.fr> (raw)
In-Reply-To: <20180417064556.EC9CE88036@busybox.osuosl.org>
Peter,
This commit should be backported to 2018.02.x to solve:
http://autobuild.buildroot.net/results/e39ca3c19e96c0c1979eb6ab59e9b2e1dc64a76c/
Thanks!
Thomas
On Tue, 17 Apr 2018 08:45:42 +0200, Thomas Petazzoni wrote:
> commit: https://git.buildroot.net/buildroot/commit/?id=107e3ebf45931adfc9c995dbb5db3bf1d17311d3
> branch: https://git.buildroot.net/buildroot/commit/?id=refs/heads/master
>
> Similar to the openocd fix in commit 5966e2dc54 (package/openocd: fix
> fallout after no-C++ fixups) the jimctl that is bundled with
> usb_modeswitch also wants to find a binary. This broke with commit
> 4cd1ab158 (core: alternate solution to disable C++). Revert to 'false'
> instead of 'no' here as well.
>
> Fixes:
> http://autobuild.buildroot.net/results/b4d/b4d4e925763cb6558af915f9781afe07fc557ebc/
> http://autobuild.buildroot.net/results/61b/61b9dc2148df2e8fd0b30e62aedbfd30bb755e19/
> http://autobuild.buildroot.net/results/468/468a7e6b049f159fbb4e79d3a12b53ca890f6933/
>
> Cc: "Yann E. MORIN" <yann.morin.1998@free.fr>
> Signed-off-by: Baruch Siach <baruch@tkos.co.il>
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
> ---
> package/usb_modeswitch/usb_modeswitch.mk | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/package/usb_modeswitch/usb_modeswitch.mk b/package/usb_modeswitch/usb_modeswitch.mk
> index 8e6b433913..d0c33cc187 100644
> --- a/package/usb_modeswitch/usb_modeswitch.mk
> +++ b/package/usb_modeswitch/usb_modeswitch.mk
> @@ -28,6 +28,7 @@ USB_MODESWITCH_POST_PATCH_HOOKS += UPDATE_CONFIG_HOOK
>
> define USB_MODESWITCH_BUILD_CMDS
> $(TARGET_MAKE_ENV) $(MAKE) $(TARGET_CONFIGURE_OPTS) \
> + $(if $(BR2_INSTALL_LIBSTDCPP),,CXX=false) \
> CFLAGS="$(TARGET_CFLAGS) -D_GNU_SOURCE -Wall -I." \
> JIM_CONFIGURE_OPTS="--host=$(GNU_TARGET_NAME) --build=$(GNU_HOST_NAME)" \
> -C $(@D) $(USB_MODESWITCH_BUILD_TARGETS)
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2018-04-20 13:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-17 6:45 [Buildroot] [git commit] usb_modeswitch: set CXX to false when C++ is missing Thomas Petazzoni
2018-04-20 13:59 ` Thomas Petazzoni [this message]
2018-04-24 19:25 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180420155957.58f2bc90@windsurf.numericable.fr \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox