From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v3 1/1] reaver: fix build errors with static lib
Date: Wed, 25 Apr 2018 22:32:36 +0200 [thread overview]
Message-ID: <20180425223236.1cf3befe@windsurf> (raw)
In-Reply-To: <1524412319-6836-1-git-send-email-guillaume.bressaix@gmail.com>
Hello,
On Sun, 22 Apr 2018 17:51:59 +0200, Guillaume W. Bres wrote:
> Signed-off-by: Guillaume W. Bres <guillaume.bressaix@gmail.com>
This commit log was way too short, and lacked a reference to the
autobuilder failure being fixed. I've fixed that when applying.
> +ifeq ($(BR2_STATIC_LIBS),y)
> +REAVER_CONF_OPTS += LIBS="`$(STAGING_DIR)/usr/bin/pcap-config --static --additional-libs`"
> +REAVER_CONF_OPTS += LDFLAGS="`$(STAGING_DIR)/usr/bin/pcap-config --static --additional-libs`"
Other issues/improvements here:
- We generally pass such variables in <pkg>_CONF_ENV
- A single <pkg>_CONF_ENV assignment is enough
- LDFLAGS shouldn't be overridden entirely: $(TARGET_LDFLAGS) still
needs to be passed.
I've fixed those different problems, and applied. See the final commit
at:
https://git.buildroot.org/buildroot/commit/?id=559416ffe2039d1cac94e348bd28e963adf008a4
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2018-04-25 20:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-22 15:51 [Buildroot] [PATCH v3 1/1] reaver: fix build errors with static lib Guillaume W. Bres
2018-04-25 20:32 ` Thomas Petazzoni [this message]
2018-04-26 8:11 ` Guillaume William Bres
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180425223236.1cf3befe@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox