From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] .gitignore: ignore outgoing directory
Date: Sat, 28 Apr 2018 18:55:22 +0200 [thread overview]
Message-ID: <20180428165522.GB2922@scaer> (raw)
In-Reply-To: <20180428184458.310770ce@windsurf>
Thomas, All,
On 2018-04-28 18:44 +0200, Thomas Petazzoni spake thusly:
> On Sun, 22 Apr 2018 10:05:32 +0200, Yann E. MORIN wrote:
> > Christopher, All,
> >
> > On 2018-03-08 06:29 -0800, Christopher McCrory spake thusly:
> > > The buildroot documentation for submitting patches creates a new
> > > directory "outgoing". This prevents git from nagging about untracked
> > > files.
> > >
> > > Signed-off-by: Christopher McCrory <chrismcc@gmail.com>
> >
> > Acked-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> >
> > Peter, this is a candidate for 2018.02.x as well, I guess. ;-)
>
> I'd like to challenge this patch: I am not super convinced. Creating a
> outgoing/ directory is not "git format-patch" default behavior. By
> default, the patches go in the current folder.
>
> It's only the Buildroot manual that suggests to put them in an
> outgoing/ folder (I'm not sure why).
And I'm not even sure why we even creat the patches locally, when it is
perfectly possible to send them directly, e.g. to send the last three
patches:
git send-email --to buidlroot at buildroot.org HEAD^^^..
Regards,
Yann E. MORIN.
> My feeling is that the Buildroot
> manual just gives an example, and really users could put their patches
> in any other folder, and we're not going to add all random folders
> in .gitignore.
>
> So I would say no to this patch, and therefore disagree with Yann's
> Acked-by. Peter, Arnout, could you chime in and give your opinion about
> this ?
>
> Best regards,
>
> Thomas
> --
> Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
> Embedded Linux and Kernel engineering
> https://bootlin.com
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
next prev parent reply other threads:[~2018-04-28 16:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-08 14:29 [Buildroot] [PATCH 1/1] .gitignore: ignore outgoing directory Christopher McCrory
2018-04-22 8:05 ` Yann E. MORIN
2018-04-28 16:44 ` Thomas Petazzoni
2018-04-28 16:55 ` Yann E. MORIN [this message]
2018-04-28 19:49 ` Thomas Petazzoni
2018-05-12 2:06 ` Carlos Santos
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180428165522.GB2922@scaer \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox