Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2 1/1] vte: new package
Date: Sat, 28 Apr 2018 23:34:26 +0200	[thread overview]
Message-ID: <20180428233426.409defbf@windsurf> (raw)
In-Reply-To: <20180116231558.7316-1-stefan.froberg@petroprogram.com>

Hello,

On Wed, 17 Jan 2018 01:15:58 +0200, Stefan Fr?berg wrote:

> diff --git a/package/vte/Config.in b/package/vte/Config.in
> new file mode 100644
> index 0000000000..43c6dd0948
> --- /dev/null
> +++ b/package/vte/Config.in
> @@ -0,0 +1,34 @@
> +config BR2_PACKAGE_VTE
> +	bool "vte"
> +	depends on BR2_USE_WCHAR
> +	depends on BR2_TOOLCHAIN_HAS_THREADS
> +	depends on BR2_USE_MMU
> +	depends on BR2_INSTALL_LIBSTDCPP
> +	depends on BR2_TOOLCHAIN_HAS_SYNC_4
> +	depends on BR2_PACKAGE_HAS_LIBEGL_WAYLAND || \
> +		BR2_PACKAGE_HAS_LIBGL
> +	depends on BR2_PACKAGE_XORG7

To be honest, I'm starting to wonder if a "depends on
BR2_PACKAGE_LIBGTK3" wouldn't make much sense in such situations. It is
likely that someone wanting to use "vte" will know that he needs
libgtk3.

But OK, I've kept it as-is.
> +comment "vte needs an OpenGL or an OpenGL-EGL/wayland backend"
> +	depends on BR2_USE_MMU
> +	depends on BR2_TOOLCHAIN_HAS_SYNC_4
> +	depends on !BR2_PACKAGE_HAS_LIBEGL_WAYLAND && \
> +		!BR2_PACKAGE_HAS_LIBGL
> +

There was an empty new line here, which I removed.

> +VTE_VERSION = 0.48.3
> +VTE_SOURCE = vte-$(VTE_VERSION).tar.xz
> +VTE_SITE = http://ftp.gnome.org/pub/gnome/sources/vte/0.48
> +VTE_DEPENDENCIES = host-pkgconf libgtk3 libxml2 pcre2
> +VTE_LICENSE = LGPL-2.1-or-later

Changed this to LGPL-2.1+, as per our conventions.

And applied. Thanks!

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com

      parent reply	other threads:[~2018-04-28 21:34 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-16 23:15 [Buildroot] [PATCH v2 1/1] vte: new package Stefan Fröberg
2018-01-23 11:49 ` Adam Duskett
2018-01-31 15:09 ` Marcus Folkesson
2018-04-28 21:30   ` Thomas Petazzoni
2018-04-28 21:34 ` Thomas Petazzoni [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180428233426.409defbf@windsurf \
    --to=thomas.petazzoni@bootlin.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox