From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 2/2] python-watchdog: add missing runtime dependency
Date: Sat, 28 Apr 2018 23:37:41 +0200 [thread overview]
Message-ID: <20180428233741.15a41dca@windsurf> (raw)
In-Reply-To: <1518787921-32089-2-git-send-email-yegorslists@googlemail.com>
Hello,
On Fri, 16 Feb 2018 14:32:01 +0100, yegorslists at googlemail.com wrote:
> From: Yegor Yefremov <yegorslists@googlemail.com>
>
> Script watchmedo requires python-setuptools.
>
> Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com>
> ---
> package/python-watchdog/Config.in | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/package/python-watchdog/Config.in b/package/python-watchdog/Config.in
> index e529089..18f569e 100644
> --- a/package/python-watchdog/Config.in
> +++ b/package/python-watchdog/Config.in
> @@ -1,8 +1,9 @@
> config BR2_PACKAGE_PYTHON_WATCHDOG
> bool "python-watchdog"
> - select BR2_PACKAGE_PYTHON_PYYAML
> - select BR2_PACKAGE_PYTHON_ARGH
> - select BR2_PACKAGE_PYTHON_PATHTOOLS
> + select BR2_PACKAGE_PYTHON_ARGH # runtime
> + select BR2_PACKAGE_PYTHON_PATHTOOLS # runtime
> + select BR2_PACKAGE_PYTHON_PYYAML # runtime
> + select BR2_PACKAGE_PYTHON_SETUPTOOLS # runtime
I applied, but since this dependency is only needed for the
watchmedo.py script, does it make sense to make this a mandatory
dependency ?
Also, skimming through the watchmedo.py script, I couldn't see what was
bringing this dependecny on setuptools. Could you enlighten me (it's
mainly for my own curiosity, I trust you when you said it was needed).
Applied, thanks!
Thomas
--
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2018-04-28 21:37 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-16 13:32 [Buildroot] [PATCH 1/2] python-watchdog: add support for uClibc yegorslists at googlemail.com
2018-02-16 13:32 ` [Buildroot] [PATCH 2/2] python-watchdog: add missing runtime dependency yegorslists at googlemail.com
2018-04-28 21:37 ` Thomas Petazzoni [this message]
2018-04-29 9:00 ` Yegor Yefremov
2018-05-01 7:32 ` Peter Korsgaard
2018-04-28 21:35 ` [Buildroot] [PATCH 1/2] python-watchdog: add support for uClibc Thomas Petazzoni
2018-04-29 8:52 ` Yegor Yefremov
2018-05-01 7:32 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180428233741.15a41dca@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox