From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] package/python-requests fix dependencies
Date: Sun, 29 Apr 2018 14:03:42 +0200 [thread overview]
Message-ID: <20180429120342.GA2424@scaer> (raw)
In-Reply-To: <20180429114038.25035-1-sven.haardiek@iotec-gmbh.de>
Sven, All,
On 2018-04-29 13:40 +0200, Sven Haardiek spake thusly:
> Requests need hashlib to run. Otherwise it is not possible to import, due to
> missing e.g. md5.
>
> Signed-off-by: Sven Haardiek <sven.haardiek@iotec-gmbh.de>
> ---
> package/python-requests/Config.in | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/package/python-requests/Config.in b/package/python-requests/Config.in
> index d2726fb26a..d51b4079cb 100644
> --- a/package/python-requests/Config.in
> +++ b/package/python-requests/Config.in
> @@ -4,6 +4,8 @@ config BR2_PACKAGE_PYTHON_REQUESTS
> select BR2_PACKAGE_PYTHON_CHARDET # runtime
> select BR2_PACKAGE_PYTHON_IDNA # runtime
> select BR2_PACKAGE_PYTHON_URLLIB3 # runtime
> + select BR2_PACKAGE_PYTHON_HASHLIB # runtime
> + select BR2_PACKAGE_PYTHON3_HASHLIB # runtime
This is definitely incorrect: you can't select for both pyhon and
python3 at the same time. See how it idoes done for SSL, just below:
> select BR2_PACKAGE_PYTHON_SSL if BR2_PACKAGE_PYTHON # runtime
> select BR2_PACKAGE_PYTHON3_SSL if BR2_PACKAGE_PYTHON3 # runtime
> select BR2_PACKAGE_PYTHON_ZLIB if BR2_PACKAGE_PYTHON # runtime
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
next prev parent reply other threads:[~2018-04-29 12:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-29 11:40 [Buildroot] [PATCH 1/1] package/python-requests fix dependencies Sven Haardiek
2018-04-29 12:03 ` Yann E. MORIN [this message]
-- strict thread matches above, loose matches on Subject: below --
2018-04-29 12:53 Sven Haardiek
2018-04-29 21:10 ` Peter Korsgaard
2018-05-01 7:33 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180429120342.GA2424@scaer \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox