From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] libebml: fix build on some toolchains
Date: Mon, 30 Apr 2018 14:05:27 +0200 [thread overview]
Message-ID: <20180430140527.3301f3bc@windsurf> (raw)
In-Reply-To: <20180430094422.5136-1-fontaine.fabrice@gmail.com>
Hello,
On Mon, 30 Apr 2018 11:44:22 +0200, Fabrice Fontaine wrote:
> Replace climits include by limits (retrieve upstream patch from:
> https://github.com/Matroska-Org/libebml/commit/e46906b80e7662fb78d305f576412f9fa4a22218)
>
> Fixes:
> - http://autobuild.buildroot.net/results/3c2402a7052acb67fc7e03ad2ff27e84534aaa36
>
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
> ...bmlSInteger-Use-limits-instead-of-climits.patch | 23 ++++++++++++++++++++++
> 1 file changed, 23 insertions(+)
> create mode 100644 package/libebml/0001-EbmlSInteger-Use-limits-instead-of-climits.patch
>
> diff --git a/package/libebml/0001-EbmlSInteger-Use-limits-instead-of-climits.patch b/package/libebml/0001-EbmlSInteger-Use-limits-instead-of-climits.patch
> new file mode 100644
> index 0000000000..3e341d0792
> --- /dev/null
> +++ b/package/libebml/0001-EbmlSInteger-Use-limits-instead-of-climits.patch
> @@ -0,0 +1,23 @@
> +From e46906b80e7662fb78d305f576412f9fa4a22218 Mon Sep 17 00:00:00 2001
> +From: =?UTF-8?q?Hugo=20Beauz=C3=A9e-Luyssen?= <hugo@beauzee.fr>
> +Date: Mon, 23 Apr 2018 12:05:42 +0200
> +Subject: [PATCH] EbmlSInteger: Use <limits> instead of <climits>
> +
> +The former is the proper header to use for std::numerical_limits
This lacks your SoB line, and it would be good to include a reference
to the upstream commit as well.
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
prev parent reply other threads:[~2018-04-30 12:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-30 9:44 [Buildroot] [PATCH 1/1] libebml: fix build on some toolchains Fabrice Fontaine
2018-04-30 12:05 ` Thomas Petazzoni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180430140527.3301f3bc@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox