From: Peter Seiderer <ps.report@gmx.net>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v3 5/6] zstd: add libzstd support
Date: Mon, 30 Apr 2018 20:48:35 +0200 [thread overview]
Message-ID: <20180430204835.26458341@gmx.net> (raw)
In-Reply-To: <20180425234831.0c8c6ce4@windsurf>
Hello Yann, Thomas,
On Wed, 25 Apr 2018 23:48:31 +0200, Thomas Petazzoni <thomas.petazzoni@bootlin.com> wrote:
> Hello,
>
> On Mon, 16 Apr 2018 21:39:52 +0200, Peter Seiderer wrote:
> > Add patch to split libzstd install target into pc, static, shared
> > and includes target. Call only the needed ones for the buildroot
> > staging/target install steps (respect the static/shared configuration).
> >
> > Signed-off-by: Peter Seiderer <ps.report@gmx.net>
> > ---
> > Changes v2 -> v3:
> > - split libray install targets for static/shared
> > (suggested by Yann E. MORIN)
>
> Applied to master after implementing the suggestion from Yann:
Thanks for review, suggestions and fixing it on the fly....
>
> [Thomas: as suggested by Yann E. Morin, refactor the build/install
> commands to use only one invocation, with intermediate ZSTD_BUILD_LIBS
> and ZSTD_INSTALL_LIBS variables, defined depending on whether
> static/shared/static+shared is selected.]
>
> Also, did you submit the patch upstream ?
Just done, see [1]...
Regards,
Peter
[1] https://github.com/facebook/zstd/pull/1114
>
> Thanks!
>
> Thomas
next prev parent reply other threads:[~2018-04-30 18:48 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-16 19:39 [Buildroot] [PATCH v3 1/6] squashfs: add license hash Peter Seiderer
2018-04-16 19:39 ` [Buildroot] [PATCH v3 2/6] zstd: add host libzstd support Peter Seiderer
2018-04-23 7:56 ` Yann E. MORIN
2018-04-25 21:37 ` Thomas Petazzoni
2018-04-16 19:39 ` [Buildroot] [PATCH v3 3/6] squashfs: add host zstd support Peter Seiderer
2018-04-23 7:57 ` Yann E. MORIN
2018-04-25 21:38 ` Thomas Petazzoni
2018-04-16 19:39 ` [Buildroot] [PATCH v3 4/6] fs/squashfs: add " Peter Seiderer
2018-04-25 21:40 ` Thomas Petazzoni
2018-04-16 19:39 ` [Buildroot] [PATCH v3 5/6] zstd: add libzstd support Peter Seiderer
2018-04-23 8:08 ` Yann E. MORIN
2018-04-25 21:48 ` Thomas Petazzoni
2018-04-30 18:48 ` Peter Seiderer [this message]
2018-04-16 19:39 ` [Buildroot] [PATCH v3 6/6] squashfs: add zstd support Peter Seiderer
2018-04-23 8:18 ` Yann E. MORIN
2018-04-25 21:49 ` Thomas Petazzoni
2018-04-25 21:34 ` [Buildroot] [PATCH v3 1/6] squashfs: add license hash Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180430204835.26458341@gmx.net \
--to=ps.report@gmx.net \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox