Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v5 2/9] gst1-plugins-${base, good, bad, ugly}: bump to 1.14.0
Date: Tue, 1 May 2018 22:49:07 +0200	[thread overview]
Message-ID: <20180501224907.14e84163@windsurf.home> (raw)
In-Reply-To: <20180501134651.8876-2-aduskett@gmail.com>

Hello Adam,

On Tue,  1 May 2018 09:46:44 -0400, Adam Duskett wrote:
> These are grouped together because several plugins have been re-arranged and
> there is no way to individually update each plugin package.
> 
> Changes:
> 
> Add the following to gst1-plugins-base and remove them from plugins-bad:
>  - opengl
>  - gles2
>  - glx
>  - egl
>  - x11
>  - dispmanx
>  - audiomixer
> 
> Add the following to plugins-good and remove them from plugins-ugly:
>  - lame
>  - mpg123
> 
> moved --disable-qt from plugins-bad to plugins-good
> 
> Also add hashes for the license files.
> 
> Signed-off-by: Adam Duskett <aduskett@gmail.com>

There are two issues with this patch:

 - You remove/rename a lot of options, but there is no Config.in.legacy
   handling for the options being removed/renamed.

 - The lame and mpg123 support is moved from plugins-ugly to
   plugins-good, but the corresponding options are not removed from
   plugins-ugly/Config.in.

Could you fix those issues, re-adjust the authorship for PATCH
8/9 (you can do that with git commit --amend --author="..."), and send
an updated version of this patch series ?

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com

  reply	other threads:[~2018-05-01 20:49 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-01 13:46 [Buildroot] [PATCH v5 1/9] gstreamer1: bump to 1.14.0 Adam Duskett
2018-05-01 13:46 ` [Buildroot] [PATCH v5 2/9] gst1-plugins-${base, good, bad, ugly}: " Adam Duskett
2018-05-01 20:49   ` Thomas Petazzoni [this message]
2018-05-02 21:12     ` Adam Duskett
2018-05-03 12:13       ` Thomas Petazzoni
2018-05-01 13:46 ` [Buildroot] [PATCH v5 3/9] gst-omx: " Adam Duskett
2018-05-01 13:46 ` [Buildroot] [PATCH v5 4/9] gst1-rtsp-server: " Adam Duskett
2018-05-01 13:46 ` [Buildroot] [PATCH v5 5/9] gst1-vaapi: " Adam Duskett
2018-05-01 13:46 ` [Buildroot] [PATCH v5 6/9] gst1-libav: " Adam Duskett
2018-05-01 13:46 ` [Buildroot] [PATCH v5 7/9] gst1-validate: " Adam Duskett
2018-05-01 13:46 ` [Buildroot] [PATCH v5 8/9] gstreamer1-editing-services: " Adam Duskett
2018-05-01 14:02   ` Adam Duskett
2018-05-01 13:46 ` [Buildroot] [PATCH v5 9/9] gst1-imx: add hash for license file Adam Duskett

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180501224907.14e84163@windsurf.home \
    --to=thomas.petazzoni@bootlin.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox