Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Petr Vorel <petr.vorel@gmail.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] ltp-testsuite: add --with-open-posix-testsuite
Date: Thu, 3 May 2018 19:21:42 +0200	[thread overview]
Message-ID: <20180503172141.GA12815@x230> (raw)
In-Reply-To: <CAFXrp_fe0s-a8F4Zh5h2gP5_krm_6vdqbd1E0MKL-3q8ENfJ6A@mail.gmail.com>

Hi Ciro,

> Ah, learned about get-developers now :-)
Thanks for tip :)


> ---------- Forwarded message ----------
> From: Ciro Santilli <ciro.santilli@gmail.com>
> Date: Thu, May 3, 2018 at 5:03 PM
> Subject: [PATCH] ltp-testsuite: add --with-open-posix-testsuite
> To: buildroot at busybox.net


> The issues mentioned on the removed comments were resolved,
> tested in QEMU x86_64 and aarch64.
Yes, I've been thinking about reenabling it again last week for the same reason :-).
Thank you for your patch.

> Signed-off-by: Ciro Santilli <ciro.santilli@gmail.com>
> ---
> This patch supposes that the removed comments imply that a default
> --with-open-posix-testsuite
> is desirable (and I confirm that it does not take unreasoble build
> time or disk space),
> and that there is no generic way to add autotools configs to packages:
> https://stackoverflow.com/questions/44341188/how-to-pass-extra-custom-configure-autotools-options-to-a-buildroot-package

>  package/ltp-testsuite/ltp-testsuite.mk | 11 +----------
>  1 file changed, 1 insertion(+), 10 deletions(-)

> diff --git a/package/ltp-testsuite/ltp-testsuite.mk
> b/package/ltp-testsuite/ltp-testsuite.mk
> index c47f587836..4584ca45da 100644
> --- a/package/ltp-testsuite/ltp-testsuite.mk
> +++ b/package/ltp-testsuite/ltp-testsuite.mk
> @@ -9,17 +9,8 @@ LTP_TESTSUITE_SOURCE = ltp-full-$(LTP_TESTSUITE_VERSION).tar.xz
>  LTP_TESTSUITE_SITE =
> https://github.com/linux-test-project/ltp/releases/download/$(LTP_TESTSUITE_VERSION)
>  LTP_TESTSUITE_LICENSE = GPL-2.0, GPL-2.0+
>  LTP_TESTSUITE_LICENSE_FILES = COPYING
> -
> -# Do not enable Open POSIX testsuite as it doesn't cross-compile
> -# properly: t0 program is built for the host machine. Notice that due
> -# to a bug, --without-open-posix-testsuite actually enables the test
> -# suite.
> -# See https://github.com/linux-test-project/ltp/issues/143 (invalid
> -# autoconf test) and
> -# https://github.com/linux-test-project/ltp/issues/144 (Open POSIX
> -# testsuite not cross-compiling).
>  LTP_TESTSUITE_CONF_OPTS += \
> - --with-realtime-testsuite
> + --with-realtime-testsuite --with-open-posix-testsuite

>  ifeq ($(BR2_LINUX_KERNEL),y)
>  LTP_TESTSUITE_DEPENDENCIES += linux

Acked-by: Petr Vorel <petr.vorel@gmail.com>


Kind regards,
Petr

  parent reply	other threads:[~2018-05-03 17:21 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-03 16:03 [Buildroot] [PATCH] ltp-testsuite: add --with-open-posix-testsuite Ciro Santilli
     [not found] ` <CAFXrp_fe0s-a8F4Zh5h2gP5_krm_6vdqbd1E0MKL-3q8ENfJ6A@mail.gmail.com>
2018-05-03 17:21   ` Petr Vorel [this message]
2018-05-03 19:55 ` Thomas Petazzoni
2018-05-03 20:01   ` Ciro Santilli
2018-05-03 20:49 ` Arnout Vandecappelle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180503172141.GA12815@x230 \
    --to=petr.vorel@gmail.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox