[Buildroot] [PATCH] binutils: replace hard-links with soft-links to fix rpath

[Yann E. MORIN <yann.morin.1998@free.fr>]

Thomas, All,

On 2018-05-06 22:26 +0200, Thomas Petazzoni spake thusly:
> On Sun, 06 May 2018 22:18:05 +0200, Peter Korsgaard wrote:
> >  > binutils installs its binaries both as bin/<tuple>-<tool> and as
> >  > <tuple>/bin/<tool>, and hardlinks are used to reduce disk space
> >  > consumption. This causes a problem for host-binutils with our rpath
> >  > fixing logic done by "make sdk".  
> > 
> >  > Indeed, the fix-rpath script starts by fixing up the rpath of
> >  > bin/<tuple>-<tool>, and sets the RPATH to $ORIGIN/../lib/. Then
> >  > fix-rpath moves on to <tuple>/bin/<tool>, and doesn't find the library
> >  > the tool depends on, and clears the RPATH. The result is that the
> >  > binutils tool are not usable.  
> > 
> >  > Note that this is only visible currently on the ARC architecture,
> >  > because on this architecture, binutils is fetched from git, which
> >  > causes host-flex to be built, and some binutils tools to use the libfl
> >  > shared library. Therefore, the binutils tools don't use just the
> >  > standard C library (which is provided by the system) but also libfl
> >  > from $(HOST_DIR)/lib, and therefore if the RPATH isn't set correctly,
> >  > those tools don't work properly.  
> > 
> >  > In order to address this, this comit adds a post-install hook to
> >  > host-binutils that replaces those hard links by symbolic links. It is
> >  > worth mentioning that library loading and RPATH usage occurs *after*
> >  > resolving the symbolic links, which makes this solution work.  
> > 
> >  > Fixes:  
> > 
> >  >   http://autobuild.buildroot.net/results/b2562b05d397d4e1ffe0f8d2f4ce4c84ab6feae1/  
> > 
> >  > Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>  
> > 
> > Committed, thanks.
> 
> Hum, I think Yann had some second thoughts about this patch. He was not
> able to reproduce the binutils tools being linked to libfl, and it also
> isn't clear why they get linked to libfl in the first place.
> 
> So, the problem is real, this patch works around it, but there's still
> a bit of mystery.

Yes, but since you had the problem, and the fix "makes sense", it's OK

Today, only binutils is affected, and I don't expect that a lot of
packages will have the same issue, so this binutils-specific fix is
also enough.

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'