Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] lxc: fix build with static libcap and shared gnutls
Date: Mon, 7 May 2018 17:44:55 +0200	[thread overview]
Message-ID: <20180507174455.34af249b@windsurf> (raw)
In-Reply-To: <CAPi7W80B9u5MkAaha=Lu6O6J1-4FAKbkN-+bgwgnrGxa5a4Dvg@mail.gmail.com>

Hello,

On Thu, 3 May 2018 23:47:17 +0200, Fabrice Fontaine wrote:

> > Do you think you could have a look into this ?
> >  
> The issue was more subtle, init_lxc is a simple binary that LXC wants to be
> statically linked if it founds a static version of the only library that it
> needs: libcap. Indeed, this binary doesn't need gnutls or any other
> dependencies such as selinux or seccomp that are needed for liblxc.
> However, because AC_CHECK_LIB was added with its default behavior of adding
> gnutls to the global LIBS variable, linking of init_lxc was failing because
> gnutls was not static.
> So, I think my patch is the right fix and it has been merged upstream:
> https://github.com/lxc/lxc/commit/49bc916b1daa79cffe38fae32059bcdd985c8c8e.
> Moreover, the issue was raised because when BR2_SHARED_LIBS is set, the
> libcap package installs the static and the shared version of the library, I
> made a patch to change this behavior but I've not send it as it didn't fix
> the root cause of the issue.

OK, I understand better. It makes sense now thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com

  reply	other threads:[~2018-05-07 15:44 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-07 16:22 [Buildroot] [PATCH 1/1] lxc: fix build with static libcap and shared gnutls Fabrice Fontaine
2018-05-03 19:40 ` Thomas Petazzoni
2018-05-03 21:47   ` Fabrice Fontaine
2018-05-07 15:44     ` Thomas Petazzoni [this message]
2018-05-07 15:45 ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180507174455.34af249b@windsurf \
    --to=thomas.petazzoni@bootlin.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox