From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/5] package/lua-flu: fix to use system xattr header
Date: Mon, 7 May 2018 22:43:02 +0200 [thread overview]
Message-ID: <20180507204302.GH14524@scaer> (raw)
In-Reply-To: <20180507212228.42f1f716@windsurf>
Thomas, All,
On 2018-05-07 21:22 +0200, Thomas Petazzoni spake thusly:
> On Mon, 7 May 2018 20:25:16 +0200, Yann E. MORIN wrote:
> > Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> > Cc: Marcin Niestroj <m.niestroj@grinn-global.com>
> > Cc: Francois Perrad <francois.perrad@gadz.org>
> > ---
> > package/lua-flu/0001-use-system-xattr-h.patch | 161 ++++++++++++++++++++++++++
> > 1 file changed, 161 insertions(+)
> > create mode 100644 package/lua-flu/0001-use-system-xattr-h.patch
> >
> > diff --git a/package/lua-flu/0001-use-system-xattr-h.patch b/package/lua-flu/0001-use-system-xattr-h.patch
> > new file mode 100644
> > index 0000000000..fda03b60c6
> > --- /dev/null
> > +++ b/package/lua-flu/0001-use-system-xattr-h.patch
> > @@ -0,0 +1,161 @@
> > +Use system <sys/xattr.h>
> > +
> > +The one from attr is no longer installed with latest version.
> > +
> > +Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
>
> This could have been a Mercurial-formatted patch. I think you know how
> to use Mercurial :-)
And no, this can't be a mercurial patch, because the luarocks infra
downloads archives from the lua package repositrory, which are
organised quite differently from the source tree.
So, the patch we carry is different from (really, a superset of) the
patch that I sent upstream:
https://bitbucket.org/doub/flu/pull-requests/1
So, no, we won't carry a mercurial-formatted patch, I'm afraid... :-(
Regards,
Yann E. MORIN.
> > +diff -durN lua-flu-20150331-1.orig/doub-flu-a7daae986339/doc/doc.lua lua-flu-20150331-1/doub-flu-a7daae986339/doc/doc.lua
> > +--- lua-flu-20150331-1.orig/doub-flu-a7daae986339/doc/doc.lua 2015-03-31 18:54:19.000000000 +0200
> > ++++ lua-flu-20150331-1/doub-flu-a7daae986339/doc/doc.lua 2018-05-06 09:22:28.499324049 +0200
> > +@@ -327,7 +327,7 @@
> > + name = "fs.getxattr";
> > + parameters = {"path", "name"};
> > + results = {"value"};
> > +- doc = [[Get an extended attribute. If the attribute doesn't exist `ENOATTR` should be thrown.]];
> > ++ doc = [[Get an extended attribute. If the attribute doesn't exist `ENODATA` should be thrown.]];
>
> I do understand all the attr/xattr.h -> sys/xattr.h changes, but I
> don't understand the ENOATTR -> ENODATA changes. Has the ENOATTR error
> code disappeared ? What makes ENODATA a suitable replacement ?
>
> Thanks!
>
> Thomas
> --
> Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
> Embedded Linux and Kernel engineering
> https://bootlin.com
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
next prev parent reply other threads:[~2018-05-07 20:43 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-07 18:25 [Buildroot] [PATCH 0/5] package: bump attr and acl, fix builds of dependees Yann E. MORIN
2018-05-07 18:25 ` [Buildroot] [PATCH 1/5] package/lua-flu: fix to use system xattr header Yann E. MORIN
2018-05-07 19:22 ` Thomas Petazzoni
2018-05-07 20:29 ` Yann E. MORIN
2018-05-07 20:51 ` Thomas Petazzoni
2018-05-07 20:43 ` Yann E. MORIN [this message]
2018-05-07 18:25 ` [Buildroot] [PATCH 2/5] package/stress-ng: bump version, " Yann E. MORIN
2018-05-07 19:23 ` Thomas Petazzoni
2018-05-07 20:32 ` Yann E. MORIN
2018-05-07 18:25 ` [Buildroot] [PATCH 3/5] package/xorriso: " Yann E. MORIN
2018-05-07 20:59 ` Yann E. MORIN
2018-05-07 18:25 ` [Buildroot] [PATCH 4/5] package/acl: bump version Yann E. MORIN
2018-05-07 18:25 ` [Buildroot] [PATCH 5/5] package/attr: " Yann E. MORIN
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180507204302.GH14524@scaer \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox