Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 3/4] package/tovid: switch from mplayer to mpv
Date: Wed, 9 May 2018 21:37:09 +0200	[thread overview]
Message-ID: <20180509213709.7a8e5c17@windsurf.home> (raw)
In-Reply-To: <20180501071017.14270-3-bernd.kuhls@t-online.de>

Hello,

On Tue,  1 May 2018 09:10:16 +0200, Bernd Kuhls wrote:
> The mplayer package will be removed from buildroot, tovid can use mpv
> instead. Support for mpv was added upstream:
> https://github.com/tovid-suite/tovid/commit/05cbce2ea130e50f6bf1599816dd0d7bf3ace91a
> 
> Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
> ---
>  package/tovid/Config.in | 17 +++++++++++------
>  1 file changed, 11 insertions(+), 6 deletions(-)
> 
> diff --git a/package/tovid/Config.in b/package/tovid/Config.in
> index d8052ea334..0d42785e8a 100644
> --- a/package/tovid/Config.in
> +++ b/package/tovid/Config.in
> @@ -6,8 +6,9 @@ config BR2_PACKAGE_TOVID
>  	depends on BR2_USE_WCHAR
>  	depends on BR2_PACKAGE_PYTHON || BR2_PACKAGE_PYTHON3
>  	depends on BR2_PACKAGE_FFMPEG_ARCH_SUPPORTS
> -	depends on BR2_PACKAGE_MPLAYER_ARCH_SUPPORTS
> -	depends on BR2_TOOLCHAIN_HAS_SYNC_4 # mplayer
> +	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_5 # mpv
> +	depends on BR2_TOOLCHAIN_HAS_ATOMIC || BR2_TOOLCHAIN_HAS_SYNC_8 # mpv
> +	depends on !BR2_TOOLCHAIN_EXTERNAL_SYNOPSYS_ARC # mpv
>  	# The below dependencies are runtime dependencies only
>  	select BR2_PACKAGE_BUSYBOX_SHOW_OTHERS # procps_ng
>  	select BR2_PACKAGE_DVDAUTHOR
> @@ -16,7 +17,7 @@ config BR2_PACKAGE_TOVID
>  	select BR2_PACKAGE_IMAGEMAGICK
>  	select BR2_PACKAGE_JPEG
>  	select BR2_PACKAGE_MJPEGTOOLS
> -	select BR2_PACKAGE_MPLAYER
> +	select BR2_PACKAGE_MPV
>  	select BR2_PACKAGE_PROCPS_NG # pgrep and pkill
>  	select BR2_PACKAGE_SOX
>  	help
> @@ -30,13 +31,17 @@ config BR2_PACKAGE_TOVID
>  comment "tovid needs a toolchain w/ threads, C++, wchar"

You forgot to update this comment...

>  	depends on BR2_USE_MMU
>  	depends on BR2_PACKAGE_FFMPEG_ARCH_SUPPORTS
> -	depends on BR2_PACKAGE_MPLAYER_ARCH_SUPPORTS
> -	depends on BR2_TOOLCHAIN_HAS_SYNC_4
> +	depends on BR2_TOOLCHAIN_HAS_ATOMIC || BR2_TOOLCHAIN_HAS_SYNC_8
>  	depends on !BR2_TOOLCHAIN_HAS_THREADS \
> +		|| !BR2_TOOLCHAIN_GCC_AT_LEAST_4_5 \

... with the addition of the gcc 4.5 dependency, so I fixed that before
applying.

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com

  reply	other threads:[~2018-05-09 19:37 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-01  7:10 [Buildroot] [PATCH 1/4] package/libplayer: remove mplayer support Bernd Kuhls
2018-05-01  7:10 ` [Buildroot] [PATCH 2/4] package/tovid: bump version Bernd Kuhls
2018-05-01  7:10 ` [Buildroot] [PATCH 3/4] package/tovid: switch from mplayer to mpv Bernd Kuhls
2018-05-09 19:37   ` Thomas Petazzoni [this message]
2018-05-01  7:10 ` [Buildroot] [PATCH 4/4] package/mplayer: remove package Bernd Kuhls
2018-05-09 19:37 ` [Buildroot] [PATCH 1/4] package/libplayer: remove mplayer support Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180509213709.7a8e5c17@windsurf.home \
    --to=thomas.petazzoni@bootlin.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox